Iss946 - Change applicable functions arguments from 'char *' to 'const char *' #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidBar-On
changed the title
bmah888
reviewed
Jun 12, 2020
There was a problem hiding this comment.
Thanks for the pull request! Going through this now and testing.
Note to self: src/cjson.c and src/cjson.h diffs are just to get these files caught up to the version of cJSON used in recent iperf3. If we merge this PR, those changes go away because they're already on the master codeline.
bmah888
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:Master
Issues fixed (if any):
Const correctness for API calls #946
Brief description of code changes (suitable for use as a commit message):
Changed functions arguments from 'char *' to 'const char *' when applicable, in 'c' and 'h' files. Hopefully all relevant cases were identified. Used test_commands.sh for sanity tests to check that changes did not cause a problem (but did not run full functionality test).