Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const correctness for API calls #946

Closed
bmah888 opened this issue Dec 23, 2019 · 1 comment · Fixed by #1006
Closed

Const correctness for API calls #946

bmah888 opened this issue Dec 23, 2019 · 1 comment · Fixed by #1006
Labels
enhancement

Comments

@bmah888
Copy link
Contributor

bmah888 commented Dec 23, 2019

If I may, for the future updates of API I would suggest all strings passed as arguments to API calls to be redesigned for 'const char *' instead of 'char *'. This would make life easier when calling them.

Originally posted by @oleh-yudin-ring in #939 (comment)
@bmah888
Copy link
Contributor Author

bmah888 commented Apr 27, 2020

This should be a pretty easy issue for someone wanting to work on iperf3.

@davidBar-On davidBar-On mentioned this issue May 23, 2020
Merged
@bmah888 bmah888 linked a pull request Jun 12, 2020 that will close this issue
Iss946 - Change applicable functions arguments from 'char *' to 'const char *' #1006
Merged
bmah888 pushed a commit that referenced this issue Jun 12, 2020
@davidBar-On
chore: Change applicable function arguments from 'char *' to 'const c…
3888e04 
…har *' (#1006)

Fixes #946.  Should not present any functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iss946 - Change applicable functions arguments from 'char *' to 'const char *' davidBar-On/iperf
1 participant
@bmah888