This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: Updates to AST node types of some TSNodes (fixes #386) #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This was referenced Sep 25, 2017
| TSSymbolKeyword: "TSSymbolKeyword", | ||
| TSTypeAnnotation: "TSTypeAnnotation", | ||
| TSTypeLiteral: "TSTypeLiteral", | ||
| TSTypeParameter: "TSTypeParameter", |
There was a problem hiding this comment.
Looks like this will conflict with TypeParameters that were already being copied over :(
Example with mapped types:
var x: { [A in keyof B]?: any };
Member
Author
There was a problem hiding this comment.
Thanks a lot for your patience on this @existentialism, I have a fix for that in prettier and have opened a PR here: prettier/prettier#3455
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.