Breaking changes to some TSNode types coming in typescript-eslint-parser

[JamesHenry]

PR: eslint/typescript-eslint-parser#388
Issue: eslint/typescript-eslint-parser#386
Background: babel/babylon#710

Should be very straightforward to track down any occurrences of the affected nodes and prefix them with TS

[weirdpattern]

What's the timeline for this @JamesHenry?
I can work on this, but can't do it before the weekend, can we wait until then?

[JamesHenry]

There shouldn't be any real pressure to update the parser in this codebase, it's not blocking any features/fixes etc

So even if the parser PR gets merged over the next few days, the plugin update can definitely wait a bit longer, just wanted to open the issue to give visibility

[weirdpattern]

Understood, then I will work on this over the weekend, as you said this should be an easy fix...

[weirdpattern]

Initial work in weirdpattern/support-updated-ts-nodes.

To test:

$ npm install eslint/typescript-eslint-parser#fbb98c416806a034bcccad765ed5a67ac880213f
$ npm run test

I will update the parser package dependency (and any other) once work on eslint/typescript-eslint-parser#386 has been completed and a new release of the parser has been published to npm.

[weirdpattern]

@JamesHenry where are we on this?
I see some of the issues/PRs have already been merged.

[JamesHenry]

Thanks for your patience on this @weirdpattern! I have submitted a PR to prettier confirming the relevant changes there too, so we are basically good to go on this now I think.

Any problems getting the plugin updated?

[weirdpattern]

No, shouldn't be a problem.
I will do it in the next couple of days, if not today....

[JamesHenry]

Ok no problem, it will be a major version bump in the parser anyway so there shouldn't be any timing issues

[weirdpattern]

If that is the case, shouldn't I wait until the parser has been updated so I can update the version in our package.json file?

[j-f1]

@weirdpattern You can just use a commit from GitHub to get the PR started, then switch to the npm version once the parser changes get released.

[weirdpattern]

@j-f1 yeah that's how I did it when I implemented the changes. I was just hoping to avoid a second (or third) rebase/commit to my code... no biggie... I will keep doing what I did before (point to the commit) then update the version...

[JamesHenry]

It's merged and I've released v10.0.0 of the parser

[weirdpattern]

Perfect, I will take it from here