Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Publish packages with provenance #86

Merged
merged 2 commits into from
Jul 11, 2024
Merged

ci: Publish packages with provenance #86

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb0627
ci: Publish packages with provenance
amareshsm Jul 9, 2024
9567369
Update release-please.yml
amareshsm Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
#-----------------------------------------------------------------------------

- name: Publish @eslint/compat package to npm
run: npm publish -w packages/compat
run: npm publish -w --provenance packages/compat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npm publish -w --provenance packages/compat
run: npm publish -w packages/compat --provenance

I believe that packages/compat must be after -w, as its value.

(the same for others)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. -w indicates the workspace (directory) to publish from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

if: ${{ steps.release.outputs['packages/compat--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
#-----------------------------------------------------------------------------

- name: Publish @eslint/core package to npm
run: npm publish -w packages/core
run: npm publish -w --provenance packages/core
if: ${{ steps.release.outputs['packages/core--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
#-----------------------------------------------------------------------------

- name: Publish @eslint/migrate-config package to npm
run: npm publish -w packages/migrate-config
run: npm publish -w --provenance packages/migrate-config
if: ${{ steps.release.outputs['packages/migrate-config--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
#-----------------------------------------------------------------------------

- name: Publish @eslint/object-schema package to npm
run: npm publish -w packages/object-schema
run: npm publish -w --provenance packages/object-schema
if: ${{ steps.release.outputs['packages/object-schema--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
#-----------------------------------------------------------------------------

- name: Publish @eslint/config-array package to npm
run: npm publish -w packages/config-array
run: npm publish -w --provenance packages/config-array
if: ${{ steps.release.outputs['packages/config-array--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down