ci: Publish packages with provenance #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
reviewed
Jul 9, 2024
.github/workflows/release-please.yml
Outdated
| @@ -54,7 +54,7 @@ jobs: | |||
| #----------------------------------------------------------------------------- | |||
|
|
|||
| - name: Publish @eslint/compat package to npm | |||
| run: npm publish -w packages/compat | |||
| run: npm publish -w --provenance packages/compat | |||
There was a problem hiding this comment.
Suggested change
| run: npm publish -w --provenance packages/compat | |
| run: npm publish -w packages/compat --provenance |
I believe that packages/compat must be after -w, as its value.
(the same for others)
There was a problem hiding this comment.
That's correct. -w indicates the workspace (directory) to publish from.
harish-sethuraman
approved these changes
Jul 10, 2024
mdjermanovic
approved these changes
Jul 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Publish packages with provenance
What changes did you make? (Give an overview)
Added the --provenance flag to npm publish commands.
Related Issues
#76
Is there anything you'd like reviewers to focus on?