refactor: use getLocFromIndex in no-invalid-label-refs
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Oct 1, 2025
src/rules/no-invalid-label-refs.js
Outdated
| * @import { Position } from "unist"; | ||
| * @import { Text } from "mdast"; | ||
| * @import { MarkdownRuleDefinition } from "../types.js"; | ||
| * @import { MarkdownSourceCode } from "../index.js"; |
There was a problem hiding this comment.
This change was motivated by #366 (comment).
The Parameters<MarkdownRuleDefinition['create']>[0]['sourceCode'] expression was needed due to a collision between rollup and tools/dedupe-types at the time, but since @eslint/markdown no longer uses rollup, it's now safe to use ../index.js.
lumirlumir
commented
Oct 1, 2025
| "![foo][]\n\n[foo]: http://bar.com/image.jpg", | ||
| "[ foo ][]\n\n[foo]: http://bar.com/image.jpg", | ||
| "[eslint][\n\n]", | ||
| "[*eslint*][]\n\n[*eslint*]: http://bar.com", |
There was a problem hiding this comment.
Using strong or emphasis inside a label is an easy-to-forget edge case and often leads to unintended side effects when the check is missed, so I've added one more test.
This is a valid label according to the AST:
|
It seems there is a problem on the macOS runner: 
|
mdjermanovic
reviewed
Oct 1, 2025
1 task
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
deleted the
refactor-use-getlocfromindex-in-no-invalid-label-refs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR originated from #536. While working on that, I found the scope had become too large, so I split this refactoring into a separate PR.
In this PR, I've used the native
getLocFromIndexmethod added in #376 instead of the customfindOffsetsutil.Notable changes:
findOffsetsutil with the nativegetLocFromIndex.What changes did you make? (Give an overview)
In this PR, I've used the native
getLocFromIndexmethod added in #376 instead of the customfindOffsetsutil.Related Issues
Ref: #376, #536
Is there anything you'd like reviewers to focus on?
N/A