feat: add support for getLocFromIndex and getIndexFromLoc

[lumirlumir]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

In this PR, I've updated the @eslint/plugin-kit and @eslint/core dependencies to add support for the getLocFromIndex and getIndexFromLoc methods.

Since these methods were already well tested in the rewrite repository, I've only added a few simple tests to verify their behavior.

What changes did you make? (Give an overview)

In this PR, I've updated the @eslint/plugin-kit and @eslint/core dependencies to add support for the getLocFromIndex and getIndexFromLoc methods.

Related Issues

Ref: eslint/rewrite#212

Is there anything you'd like reviewers to focus on?

N/A

Prerequisite

• feat: add support for getLocFromIndex and getIndexFromLoc rewrite#212
• perf: improve time complexity of getLocFromIndex eslint#19782

[nzakas]

Before you get too far on this, is this function currently needed? As discussed in eslint/rewrite#166, this is an expensive operation and I don't think we want to incorporate it unless we absolutely need it.

[lumirlumir]

@nzakas

I thought this method could replace the findOffsets method used throughout the rules in @eslint/markdown, so I saw it as both a refactor and a new feature.

It’s currently used in two rules, and I use this kind of logic in my own rules as well (for context, please see https://github.com/lumirlumir/npm-eslint-plugin-mark/blob/main/packages/eslint-plugin-mark/src/core/ast/text-handler/text-handler.js).

If this feature isn’t necessary for now, I’ll go ahead and close it.

---

(If it is fine, I would like to keep exploring and look for a more performant solution.)

[nzakas]

@lumirlumir ah, I forgot about that. Gotcha. 👍 If you're going to go through the trouble of investigating, then I'd suggest doing it on TextSourceCodeBase so every project can benefit.

[lumirlumir]

@nzakas Thanks for understanding!

I’ll keep this PR open for now, move on to implementing TextSourceCodeBase, and then come back to this one afterward.

Can I assign myself for the issue I've created? eslint/rewrite#166

[nzakas]

Go ahead.

[nzakas]

The other thing to keep in mind is that findOffsets() is not always used from the beginning of the document. Like in this case:

markdown/src/rules/no-html.js

Line 71 in cb5a956

const { lineOffset, columnOffset } = findOffsets(

It's finding the offset inside a given node's text.

[github-actions]

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

[mdjermanovic]

As @eslint/plugin-kit v0.4.0 has been released, we could now continue work here?

[lumirlumir]

There was some delay on my end with the markdown plugin. I'll work on it soon! 👍

[lumirlumir]

I've used the markdownSourceCode name here because the following errors occur:

110:10  error  'sourceCode' is already declared in the upper scope on line 63 column 6  no-shadow
173:10  error  'sourceCode' is already declared in the upper scope on line 63 column 6  no-shadow

[mdjermanovic]

LGTM, thanks!