Skip to content

feat: migrate playground to ESLint v10 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pixel998 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: migrate playground to ESLint v10 #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/playground/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
'/* eslint quotes: ["error", "double"] */\nconst a = \'b\';';

const linter = new Linter({ configType: "flat" });
const legacyLinter = new Linter({ configType: "eslintrc" });
Copy link
Member

@mdjermanovic mdjermanovic Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this wouldn't work with ESLint v10 so we have to figure out another way to get rules.

Copy link
Member

@mdjermanovic mdjermanovic Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem was discussed in eslint/eslint#18103, and a proposed solution that could do the work is to fetch rules_meta.json from the eslint/eslint repo's latest branch.

const rules = legacyLinter.getRules();

Check failure on line 30 in src/playground/App.js

View workflow job for this annotation

GitHub Actions / Lint 

'legacyLinter' is not defined
const ruleNames = Array.from(rules.keys());
const rulesMeta = Array.from(rules.entries()).reduce((result, [key, value]) => {
result[key] = value.meta;
Expand Down
Loading