-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat: migrate playground to ESLint v10 #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| '/* eslint quotes: ["error", "double"] */\nconst a = \'b\';'; | ||
|
|
||
| const linter = new Linter({ configType: "flat" }); | ||
| const legacyLinter = new Linter({ configType: "eslintrc" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this wouldn't work with ESLint v10 so we have to figure out another way to get rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem was discussed in eslint/eslint#18103, and a proposed solution that could do the work is to fetch rules_meta.json from the eslint/eslint repo's latest branch.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?