Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Withdrawal req #234

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Change Withdrawal req #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions types/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ message DepositRequest {
}

message WithdrawalRequest {
H160 source_address = 1;
bytes validator_pubkey = 2;
uint64 amount = 3;
bytes request_data = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we merge deposit/withdrawal/consolidation requests together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i will merge them with a subsequent PR, these are small progressions of changes to make reviewing easier.

}

message ConsolidationRequest {
Expand Down