Change Withdrawal req #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 11, 2024
In summary, does away with a lot of earlier complexities related to parsing and encoding withdrawal requests. These are now just byte strings, essentially Refer to the following - ethereum/EIPs#8855 (flat requests format update for EIP-7002) - https://github.com/ethereum/EIPs/pull/8934/files#diff-70472fac1debb567783ce13873323261713f3ce488a26a5c3769a9193f4a7e27R596 (Address update) Needs interface update - erigontech/interfaces#234 (Tasks board - #12106)
yperbasis
reviewed
Oct 11, 2024
| H160 source_address = 1; | ||
| bytes validator_pubkey = 2; | ||
| uint64 amount = 3; | ||
| bytes request_data = 1; |
There was a problem hiding this comment.
Shouldn't we merge deposit/withdrawal/consolidation requests together?
There was a problem hiding this comment.
Yes, i will merge them with a subsequent PR, these are small progressions of changes to make reviewing easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.