Skip to content

rpc: trace_transaction return error if block is non-canonical #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AskAlexSharov merged 3 commits into from
Mar 8, 2024
Merged

rpc: trace_transaction return error if block is non-canonical #9641

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
499526c
save
AskAlexSharov Mar 8, 2024
9fcc21d
save
AskAlexSharov Mar 8, 2024
a1934d7
save
AskAlexSharov Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions turbo/jsonrpc/trace_filtering.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,21 @@ func (api *TraceAPIImpl) Transaction(ctx context.Context, txHash common.Hash, ga
}

var txIndex int
for idx := 0; idx < block.Transactions().Len() && !isBorStateSyncTxn; idx++ {
txn := block.Transactions()[idx]
if txn.Hash() == txHash {
txIndex = idx
break
}
}

if isBorStateSyncTxn {
txIndex = block.Transactions().Len()
} else {
var found bool
for idx := 0; idx < block.Transactions().Len(); idx++ {
txn := block.Transactions()[idx]
if txn.Hash() == txHash {
txIndex = idx
found = true
break
}
}
if !found {
return nil, fmt.Errorf("txn with hash %x belongs to currentely non-canonical block %d. only canonical blocks can be traced", txHash, block.NumberU64())
}
}

bn := hexutil.Uint64(blockNumber)
Expand Down