rpc: trace_transaction return error if block is non-canonical #9641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested changes
Mar 8, 2024
yperbasis
reviewed
Mar 8, 2024
turbo/jsonrpc/trace_filtering.go
Outdated
| } | ||
| } | ||
| if !found { | ||
| return nil, fmt.Errorf("block with hash %x is not currently canonical. blockNum=%d, txnHash=%x", block.Hash(), block.NumberU64(), txHash) |
Member
There was a problem hiding this comment.
I think it's the other way round. Block is canonical, transaction is not. Right?
yperbasis
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #8572 (comment)
and #9616