Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates regarding fallback #1

Merged
merged 5 commits into from
Aug 13, 2024
Merged

updates regarding fallback #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c03d7d
updates regarding falback
livingrockrises Aug 10, 2024
cd1b0fe
respind to PR comments
livingrockrises Aug 13, 2024
96b9f22
Update ERCS/erc-7579.md
livingrockrises Aug 13, 2024
f8f618a
Update ERCS/erc-7579.md
livingrockrises Aug 13, 2024
9b79f3e
Update ERCS/erc-7579.md
livingrockrises Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ERCS/erc-7579.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,8 @@ Smart accounts MAY implement a fallback function that forwards the call to a fal

If the smart account has a fallback handler installed, it:

- MUST implement authorization control
kopy-kat marked this conversation as resolved.
Show resolved Hide resolved
- MUST use `call` to invoke the fallback handler
- MUST utilize [ERC-2771](./eip-2771.md) to add the original `msg.sender` to the `calldata` sent to the fallback handler
- MUST use `call` or `staticcall` to invoke the fallback handler
- MUST utilize [ERC-2771](./eip-2771.md) to add the original `msg.sender` to the `calldata` sent to the fallback handler. Authorization control MAY be implemented by the fallback handler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo Authorization control MAY be implemented by the fallback handler would fit better into the Fallback Handlers section under Modules since thats where behaviours that modules should implement are defined

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean under Module Configurations right?
section where above comment is in this review

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted this and added at recommended place.

- MUST route to fallback handlers based on the function selector of the calldata

#### ERC-165
Expand Down