updates regarding fallback #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopy-kat
reviewed
Aug 11, 2024
kopy-kat
reviewed
Aug 11, 2024
ERCS/erc-7579.md
Outdated
| - MUST use `call` to invoke the fallback handler | ||
| - MUST utilize [ERC-2771](./eip-2771.md) to add the original `msg.sender` to the `calldata` sent to the fallback handler | ||
| - MUST use `call` or `staticcall` to invoke the fallback handler | ||
| - MUST utilize [ERC-2771](./eip-2771.md) to add the original `msg.sender` to the `calldata` sent to the fallback handler. Authorization control MAY be implemented by the fallback handler |
There was a problem hiding this comment.
Imo Authorization control MAY be implemented by the fallback handler would fit better into the Fallback Handlers section under Modules since thats where behaviours that modules should implement are defined
There was a problem hiding this comment.
you mean under Module Configurations right?
section where above comment is in this review
There was a problem hiding this comment.
reverted this and added at recommended place.
kopy-kat
reviewed
Aug 13, 2024
kopy-kat
reviewed
Aug 13, 2024
kopy-kat
reviewed
Aug 13, 2024
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: