Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename task.nameto task.type #239

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

anetteu
Copy link
Member

@anetteu anetteu commented Apr 6, 2022

The previous task.name is not a unique name for a task, but a
description of the type of task, for example take_image.

Resolves #157

The previous `task.name` is not a unique name for a task, but a
description of the type of task, for example `take_image`.
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vetlek vetlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anetteu anetteu merged commit da4793c into equinor:main Apr 8, 2022
@anetteu anetteu deleted the rename-name-type branch April 8, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using 'type' instead of 'name' for type of task in a mission
3 participants