Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using 'type' instead of 'name' for type of task in a mission #157

Closed
tsundvoll opened this issue Dec 8, 2021 · 3 comments · Fixed by #239
Closed

Consider using 'type' instead of 'name' for type of task in a mission #157

tsundvoll opened this issue Dec 8, 2021 · 3 comments · Fixed by #239
Assignees
Labels
good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@tsundvoll
Copy link
Contributor

Describe the improvement you would like to see
Today we tag each task in a mission with a 'name'. Probably a more precise wording would be 'type'.
For example for DriveToPose. The resulting predefined mission would look something like this.

"tasks": [
        {
            "type": "drive_to_pose",
            "pose": {
                "position": {
                    "x": -3.6,
                    ....
            }
        },

How will this change existing functionality?
Nothing, just a refactor

How will this improvement affect the current Threat Model?
Nothing

@tsundvoll tsundvoll added the improvement Improvement to existing functionality label Dec 8, 2021
@aeshub aeshub added the good first issue Good for newcomers label Dec 8, 2021
@PracticalMetal
Copy link

Hey, I would like to work on this, can you suggest me ways to get started?

@tsundvoll
Copy link
Contributor Author

Hey, I would like to work on this, can you suggest me ways to get started?

That is great @PracticalMetal. You can start by having a look at
src/robot_interface/models/mission/task.py.
Here we define different dataclasses that are different types of tasks that can make up a robot mission. This issue is to rename the name attribute of those dataclasses to type instead.

Furthermore, we have some example missions in the
src/isar/config/predefined_missions/ folder.
The tasks listed in those files also need to swap name with task.

That should be it for this issue. We are happy to receive a PR on this from your forked version of this repo.

@PracticalMetal
Copy link

Sorry for the late reply, I will be working on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
4 participants