Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(bookmark): align with existing code #2691

Merged
merged 21 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
303a8fd
refactor(bookmarks): update BookmarkProvider references to use IBookm…
odinr Dec 11, 2024
c252f9e
feat(bookmarks): add enableBookmark function for application integration
odinr Dec 11, 2024
6273ff8
refactor(cli): update BookmarkSideSheet to use component context
odinr Dec 11, 2024
a743f27
refactor(bookmarks): align React wiring with IBookmarkProvider interface
odinr Dec 11, 2024
7ffc348
fix(component-bookmark): minor adjustments
odinr Jan 6, 2025
a7ed939
fix(cli): updated bookmark component
odinr Jan 6, 2025
d4afa12
fix: updated bookmark cookbook
odinr Jan 6, 2025
e8356c6
chore: update lock file
odinr Jan 6, 2025
8539faa
fix(App): change console.log to console.warn for missing entryPoint
odinr Jan 20, 2025
e113b7d
fix(enable-bookmark): remove console.log for disposing bookmark module
odinr Jan 20, 2025
e3375ec
fix(cli): replace console.log with console.error for error handling i…
odinr Jan 20, 2025
ad669cd
fix(CreateBookmark): improve error handling and logging in createBook…
odinr Jan 20, 2025
dce9368
fix(bookmark): improve provider handling and update logging in bookma…
odinr Jan 20, 2025
a74deb3
fix(bookmark): enhance typing and conversion from API, update bookmar…
odinr Jan 20, 2025
cd5cef5
feat(bookmark): add support for user bookmarks v2 with enhanced filte…
odinr Jan 20, 2025
156d0f5
feat(Header): implement HeaderActions component and improve bookmark …
odinr Jan 20, 2025
4e08b7b
fix(flows): replace console.log with console.error for better error l…
odinr Jan 20, 2025
5689a67
refactor(bookmark): update bookmark parsing logic and deprecate outda…
odinr Jan 24, 2025
fab9525
docs(bookmark): add usage tips and examples for shared payload manage…
odinr Jan 24, 2025
0655e4f
fix(bookmark): improve handling of generator return values in Bookmar…
odinr Jan 24, 2025
f4e98bc
fix(header): update Icon usage for tag in Header.Actions component
odinr Jan 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: updated bookmark cookbook
  • Loading branch information
odinr committed Jan 27, 2025
commit d4afa12b0b6f44dc8b376df7403b99b771e36c9a
5 changes: 5 additions & 0 deletions .changeset/stupid-maps-count.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@equinor/fusion-framework-cookbook-app-react-bookmark': patch
---

updated bookmark test app
7 changes: 7 additions & 0 deletions cookbooks/app-react-bookmark/app.manifest.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { defineAppManifest } from '@equinor/fusion-framework-cli';

export default defineAppManifest(() => {
return {
appKey: 'bookmark',
};
});
2 changes: 1 addition & 1 deletion cookbooks/app-react-bookmark/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@equinor/fusion-framework-cookbook-app-react-bookmark",
"version": "4.2.0",
"version": "4.2.0-beta.7",
"description": "",
"private": true,
"type": "module",
Expand Down
4 changes: 2 additions & 2 deletions cookbooks/app-react-bookmark/src/config.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { AppModuleInitiator } from '@equinor/fusion-framework-react-app';
import type { AppModuleInitiator, IAppConfigurator } from '@equinor/fusion-framework-react-app';

import { enableContext } from '@equinor/fusion-framework-module-context';
import { enableBookmark } from '@equinor/fusion-framework-react-app/bookmark';

export const configure: AppModuleInitiator = (configurator) => {
export const configure: AppModuleInitiator = (configurator: IAppConfigurator) => {
enableContext(configurator, async (builder) => {
builder.setContextType(['projectMaster']); // set contextType to match against
});
Expand Down
24 changes: 0 additions & 24 deletions cookbooks/app-react-bookmark/tsconfig.docker.json

This file was deleted.

3 changes: 1 addition & 2 deletions cookbooks/app-react-bookmark/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"rootDir": "src",

"jsx": "react-jsxdev",
"jsx": "react-jsx",
},
"references": [
{
Expand Down