-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(bookmark): align with existing code #2691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa75ea3
to
0df9d8f
Compare
0df9d8f
to
36ca730
Compare
🦋 Changeset detectedLatest commit: f4e98bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6a4a61b
to
8a084c0
Compare
Noggling
reviewed
Jan 24, 2025
Noggling
reviewed
Jan 24, 2025
Noggling
reviewed
Jan 24, 2025
Noggling
approved these changes
Jan 24, 2025
…arkProvider interface
…k actions and schemas
…ring and response schemas
…ted methods in BookmarkProvider
cbc825a
to
f4e98bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
🚧 chore
maintaines work, (update deps, workflos ...)
💾 CLI
fusion framework CLI
👨🏻🍳 cookbooks
📚 documentation
Improvements or additions to documentation
🚀 feature
New feature or request
🧬 Modules
👾 React
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Update the bookmarks module to use the IBookmarkProvider interface, add an enableBookmark function for better application integration, and refactor related components for improved context handling. Minor fixes and adjustments were also made to enhance overall functionality.
closes:
Check off the following:
Confirm that I checked changes to branch which I am merging into.
Confirm that the I have completed the self-review checklist.
Confirm that my changes meet our code of conduct.