Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(bookmark): align with existing code #2691

Merged
merged 21 commits into from
Jan 27, 2025

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Jan 9, 2025

Why

Update the bookmarks module to use the IBookmarkProvider interface, add an enableBookmark function for better application integration, and refactor related components for improved context handling. Minor fixes and adjustments were also made to enhance overall functionality.

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

@github-actions github-actions bot added 🐞 bug Something isn't working 👨🏻‍🍳 cookbooks 👾 React 💾 CLI fusion framework CLI 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request labels Jan 9, 2025
@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from aa75ea3 to 0df9d8f Compare January 9, 2025 11:23
@github-actions github-actions bot added 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules labels Jan 9, 2025
@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from 0df9d8f to 36ca730 Compare January 10, 2025 12:55
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: f4e98bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-module-bookmark Minor
@equinor/fusion-framework-cli Minor
@equinor/fusion-framework-module-services Minor
@equinor/fusion-framework-react-module-bookmark Minor
@equinor/fusion-framework-cookbook-app-react-bookmark Patch
@equinor/fusion-framework-react-app Minor
@equinor/fusion-framework-app Minor
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-legacy-interopt Major
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-react-widget Patch
@equinor/fusion-framework-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from 6a4a61b to 8a084c0 Compare January 24, 2025 09:34
@odinr odinr marked this pull request as ready for review January 24, 2025 09:45
@odinr odinr requested a review from a team as a code owner January 24, 2025 09:45
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.37% 1751 / 463502
🔵 Statements 0.37% 1751 / 463502
🔵 Functions 23% 207 / 900
🔵 Branches 36.95% 388 / 1050
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
cookbooks/app-react-bookmark/app.manifest.config.ts 0% 0% 0% 0% 1-7
cookbooks/app-react-bookmark/src/config.ts 0% 0% 0% 0% 1-13
packages/app/src/enable-bookmark.ts 0% 100% 100% 0% 7-72
packages/cli/src/bin/dev-portal/BookMarkSideSheet.tsx 0% 0% 0% 0% 1-36
packages/cli/src/bin/dev-portal/Header.Actions.tsx 0% 0% 0% 0% 1-43
packages/cli/src/bin/dev-portal/Header.tsx 0% 0% 0% 0% 1-89
packages/cli/src/bin/dev-portal/Router.tsx 0% 0% 0% 0% 1-79
packages/cli/src/bin/dev-portal/config.ts 0% 0% 0% 0% 1-82
packages/cli/src/bin/utils/getEndpointUrl.ts 0% 0% 0% 0% 1-61
packages/cli/src/bin/utils/publishAppConfig.ts 0% 0% 0% 0% 1-33
packages/cli/src/bin/utils/tagAppBundle.ts 0% 0% 0% 0% 1-32
packages/modules/app/src/app/App.ts 0% 0% 0% 0% 1-902
packages/modules/bookmark/src/BookmarkClient.interface.ts 100% 100% 100% 100%
packages/modules/bookmark/src/BookmarkClient.ts 0% 0% 0% 0% 1-261
packages/modules/bookmark/src/BookmarkConfigurator.ts 0% 0% 0% 0% 1-378
packages/modules/bookmark/src/BookmarkProvider.actions.ts 0% 0% 0% 0% 1-129
packages/modules/bookmark/src/BookmarkProvider.events.ts 100% 100% 100% 100%
packages/modules/bookmark/src/BookmarkProvider.flows.ts 0% 0% 0% 0% 1-435
packages/modules/bookmark/src/BookmarkProvider.interface.ts 100% 100% 100% 100%
packages/modules/bookmark/src/BookmarkProvider.selectors.ts 0% 100% 100% 0% 5-54
packages/modules/bookmark/src/BookmarkProvider.ts 0% 0% 0% 0% 1-1418
packages/modules/bookmark/src/bookmark-config.schema.ts 0% 0% 0% 0% 1-45
packages/modules/bookmark/src/bookmark-module.ts 0% 0% 0% 0% 1-71
packages/modules/bookmark/src/bookmark.schemas.ts 0% 0% 0% 0% 1-49
packages/modules/bookmark/src/index.ts 0% 0% 0% 0% 1-28
packages/modules/bookmark/src/types.ts 100% 100% 100% 100%
packages/modules/services/src/bookmarks/index.ts 0% 0% 0% 0% 1-3
packages/modules/services/src/bookmarks/schemas.ts 0% 0% 0% 0% 1-81
packages/modules/services/src/bookmarks/endpoints/user-bookmarks.get.ts 0% 0% 0% 0% 1-158
packages/modules/widget/src/state/flows.ts 0% 0% 0% 0% 1-75
packages/react/app/src/bookmark/index.ts 0% 0% 0% 0% 1
packages/react/components/bookmark/src/index.ts 0% 0% 0% 0% 1
packages/react/components/bookmark/src/components/Bookmark.tsx 0% 0% 0% 0% 1-92
packages/react/components/bookmark/src/components/BookmarkProvider.tsx 0% 0% 0% 0% 1-105
packages/react/components/bookmark/src/components/create-bookmark/CreateBookmark.tsx 0% 0% 0% 0% 1-120
packages/react/components/bookmark/src/components/edit-bookmark/EditBookmark.tsx 0% 0% 0% 0% 1-186
packages/react/components/bookmark/src/components/import-bookmark/ImportBookmark.tsx 0% 0% 0% 0% 1-92
packages/react/components/bookmark/src/components/row/Row.tsx 0% 0% 0% 0% 1-98
packages/react/components/bookmark/src/components/sectionList/SectionList.tsx 0% 0% 0% 0% 1-168
packages/react/modules/bookmark/src/useBookmark.ts 0% 0% 0% 0% 1-185
packages/react/modules/bookmark/src/useBookmarkProvider.ts 0% 0% 0% 0% 1-9
packages/react/modules/bookmark/src/useCurrentBookmark.ts 0% 0% 0% 0% 1-63
packages/react/modules/bookmark/src/portal/useHasBookmark.ts 0% 0% 0% 0% 1-20
Generated in workflow #8472 for commit f4e98bc by the Vitest Coverage Report Action

@odinr odinr changed the title Fix/bookmark/align with existing code Fix(bookmark): align with existing code Jan 24, 2025
@odinr odinr self-assigned this Jan 24, 2025
@odinr odinr requested a review from Noggling January 24, 2025 10:11
@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from cbc825a to f4e98bc Compare January 27, 2025 09:59
@odinr odinr merged commit 6ead547 into main Jan 27, 2025
7 checks passed
@odinr odinr deleted the fix/bookmark/align-with-existing-code branch January 27, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 💾 CLI fusion framework CLI 👨🏻‍🍳 cookbooks 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request 🧬 Modules 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants