forked from NVIDIA/cuda-quantum
-
Couldn't load subscription status.
- Fork 0
Update ServerHelper protocol #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup
set default server path to mock_qpu target
AndreiCod
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
szilveszteri
added a commit
that referenced
this pull request
Nov 14, 2024
* add configuration options cleanup * quick fix error message extraction * update mock_qpu protocol set default server path to mock_qpu target
szilveszteri
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Started putting together docs for `braket` target Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Add link to example notebooks (#3) * Move the target to hardware section * Expand with links to hybrid jobs, setting credentials etc. Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Restore a target link that was accidentally removed. * Restore simulators docs page Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Spelling fix (not sure why suddenly spell checker is complaining about the email address in OQC docs) Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * DCO Remediation Commit for Tim (Yi-Ting) <yitchen@amazon.com> (#4) I, Tim (Yi-Ting) <yitchen@amazon.com>, hereby add my Signed-off-by to this commit: 2fc65f8 * DCO remediation (#5) * DCO Remediation Commit for Tim (Yi-Ting) <yitchen@amazon.com> I, Tim (Yi-Ting) <yitchen@amazon.com>, hereby add my Signed-off-by to this commit: 2fc65f8 * DCO Remediation Commit for Tim (Yi-Ting) <yitchen@amazon.com> I, Tim (Yi-Ting) <yitchen@amazon.com>, hereby add my Signed-off-by to this commit: fe0f328 Signed-off-by: Tim (Yi-Ting) <yitchen@amazon.com> Signed-off-by: Tim <yitchen@amazon.com> --------- Signed-off-by: Tim (Yi-Ting) <yitchen@amazon.com> Signed-off-by: Tim <yitchen@amazon.com> * Basic examples for `braket` target added * Skip automated validation on the newly added examples. --------- Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> Signed-off-by: Tim (Yi-Ting) <yitchen@amazon.com> Signed-off-by: Tim <yitchen@amazon.com> Co-authored-by: Tim (Yi-Ting) <yitchen@amazon.com>
szilveszteri
added a commit
that referenced
this pull request
Nov 29, 2024
* add configuration options cleanup * quick fix error message extraction * update mock_qpu protocol set default server path to mock_qpu target
szilveszteri
pushed a commit
that referenced
this pull request
Mar 31, 2025
* Fine-grain kraus channel application in a kernel * updates * compile time checks for number of args * better type safety on input args * cleanup * small fixes * update to use integer key for registry * remove old headers * remove the name member * [core] Support for apply_noise. Add an apply_noise operator. Teach the bridge to recognize cudaq::apply_noise and lower it. Add a pass to erase apply_noise operations. Modify QIR codegen to generate the C++ callback. Make test for elimination more robust. Arguments have to be passed by rvalue reference since some of them are qubits, which cannot be copied. Thread the pointer through all the places where there were floating-point types. Update tests. Add a bit more smart to the cudaq::apply_noise stub. Automatically counts the leading number of floating-point arguments, so the user doesn't have to supply this information. Uses the applyNoiseImpl<> template as is. Add some constraints to fine-tune the apply_noise overload selection. Add std::vector<double> overload processing to the bridge. * Make the key an i64 and verify it. * Rope off the C++20 sections. * Make the noise_func symbol optional. * Add to the roundtrip test. * Fix test. * Fix signature. * Add cc.call_vararg op. * Add codegen test. * Fix test. * Enable C++17 in the headers. * Add python support for apply_noise (#4) * Start on Python apply_noise support * add some docs * Extend __quantum__qis__apply_kraus_channel_generalized() to support spans as part of the variadic arguments. * Fix typo. * Content checks. * Do it again.* And again. * Catch curious exception being thrown. * More whining about formatting. * Try to exclude register_channel to avoid the error. * Take care of review comments. * Address PR comments, checks on corner cases, warnings emitted * Better noise model checking, handle cases with no context * Rework the noise model header files to support float and double. * clang-format * Add enum to the apply_noise entry point to select the floating point type. * Move template to lambda. * Fix a bug and more unit tests. * Add another test. --------- Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Alex McCaskey <amccaskey@nvidia.com>
szilveszteri
pushed a commit
that referenced
this pull request
Mar 31, 2025
* initial work * Orginazing Pasqal files (#3) * fix PasqalServerHelper * fix CMakeLists * Minor cosmetic changes * Fix constant values Also: * Python imports in alphabetical order * Fix `analog_targets` list declaration on `evolution.py` * Helper methods implementation (#4) Implement the following methods: * `extractJobId` * ` constructGetJobPath` (both variants) * `jobIsDone` * `processResults` (without index order verification) * fix field name on payload * fix `createJob` path * begin docs * Add PasqalTester * [hotfix] Pasqal `constructGetJobPath` * Review on Pasqal files (#10) * Add `project_id` to payload. * Fix `extractJobId` path. * fix machine and user-agent information * push machine from config * DCO Remediation Commit for Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> I, Aleksander Wennersteen <aleksander.wennersteen@pasqal.com>, hereby add my Signed-off-by to this commit: 8d323f2 I, Aleksander Wennersteen <aleksander.wennersteen@pasqal.com>, hereby add my Signed-off-by to this commit: 9665a97 Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: fb77b36 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: cb78788 I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: 734dad9 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * DCO Remediation Commit for Kaonan Micadei <kaosmicadei@users.noreply.github.com> I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: f35782c I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 451c414 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 48eb189 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e320af0 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0e36977 Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: 04efb12 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * Update PasqalServerHelper.cpp DCO Remediation Commit for Kaonan Micadei <kaosmicadei@users.noreply.github.com> I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: f35782c I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 451c414 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 48eb189 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e320af0 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0e36977 Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> * Minor edits on docs Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * [fix] Pasqal payload format Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * Fix issues preventing correct execution and update example Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Apply basic CR Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * target opt-out Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * Test behavior from C++ frontend when using `pasqal` target * Moved test to common `analog` directory Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Fix code to use new results json structure Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Apply yapf formatting to Python Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix docs rendering Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Integration test Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix integration test - missing dependency Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix behaviour when job fails; fix constant in doc example Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * fix spell check Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Update example to show how to target QPU * Modified tests - removed the one which is repeat of the example * Updated logos to add new hardware target * Check for the password in environment variables Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Update docs and remove todo Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * results now in big-endian Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * Updated logo Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> --------- Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> Co-authored-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Co-authored-by: Kaonan Micadei <k.micadei@gmail.com> Co-authored-by: Kaonan Micadei <kaonan.micadei@pasqal.com> Co-authored-by: Pradnya Khalate <pkhalate@nvidia.com> Co-authored-by: Pradnya Khalate <148914294+khalatepradnya@users.noreply.github.com>
szilveszteri
added a commit
that referenced
this pull request
Apr 1, 2025
* add configuration options cleanup * quick fix error message extraction * update mock_qpu protocol set default server path to mock_qpu target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.