Added support for local pipeline development #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| devicePassPipeline = queryPassPipeline(); | ||
|
|
||
| if (config.count("emulate") && config["emulate"] == "false") |
There was a problem hiding this comment.
what happens if config.count("emulate") equals to 0?
That means it will assume no emulation instead of not config not existing
There was a problem hiding this comment.
Basically we assume that if the "emulate" keyword is not present we are not emulating. I'm not sure if the key is required to be present in the config dictionary. This is the reason why I implemented it like this
There was a problem hiding this comment.
but if the emulate keyword is not present, then we will not get into the if-branch cause count will return 0 right ?
| if (config.count("emulate") && config["emulate"] == "false") | ||
| devicePassPipeline = queryPassPipeline(); | ||
| else | ||
| devicePassPipeline = "canonicalize"; |
There was a problem hiding this comment.
can we put "const-prop-complex, canonicalize, cse" as the pipeline? It can make IR more readable if we will get to debug it
szilveszteri
approved these changes
Dec 10, 2024
szilveszteri
pushed a commit
that referenced
this pull request
Mar 31, 2025
* initial work * Orginazing Pasqal files (#3) * fix PasqalServerHelper * fix CMakeLists * Minor cosmetic changes * Fix constant values Also: * Python imports in alphabetical order * Fix `analog_targets` list declaration on `evolution.py` * Helper methods implementation (#4) Implement the following methods: * `extractJobId` * ` constructGetJobPath` (both variants) * `jobIsDone` * `processResults` (without index order verification) * fix field name on payload * fix `createJob` path * begin docs * Add PasqalTester * [hotfix] Pasqal `constructGetJobPath` * Review on Pasqal files (#10) * Add `project_id` to payload. * Fix `extractJobId` path. * fix machine and user-agent information * push machine from config * DCO Remediation Commit for Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> I, Aleksander Wennersteen <aleksander.wennersteen@pasqal.com>, hereby add my Signed-off-by to this commit: 8d323f2 I, Aleksander Wennersteen <aleksander.wennersteen@pasqal.com>, hereby add my Signed-off-by to this commit: 9665a97 Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: fb77b36 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: cb78788 I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: 734dad9 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * DCO Remediation Commit for Kaonan Micadei <kaosmicadei@users.noreply.github.com> I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: f35782c I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 451c414 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 48eb189 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e320af0 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0e36977 Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> * DCO Remediation Commit for Kaonan Micadei <k.micadei@gmail.com> I, Kaonan Micadei <k.micadei@gmail.com>, hereby add my Signed-off-by to this commit: 04efb12 Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * Update PasqalServerHelper.cpp DCO Remediation Commit for Kaonan Micadei <kaosmicadei@users.noreply.github.com> I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: f35782c I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 451c414 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 48eb189 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e320af0 I, Kaonan Micadei <kaosmicadei@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0e36977 Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> * Minor edits on docs Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * [fix] Pasqal payload format Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> * Fix issues preventing correct execution and update example Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Apply basic CR Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * target opt-out Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * Test behavior from C++ frontend when using `pasqal` target * Moved test to common `analog` directory Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Fix code to use new results json structure Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Apply yapf formatting to Python Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix docs rendering Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Integration test Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix integration test - missing dependency Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Fix behaviour when job fails; fix constant in doc example Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * fix spell check Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * Update example to show how to target QPU * Modified tests - removed the one which is repeat of the example * Updated logos to add new hardware target * Check for the password in environment variables Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> * Update docs and remove todo Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> * results now in big-endian Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> * Updated logo Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> --------- Signed-off-by: Aleksander Wennersteen <aleksander.wennersteen@pasqal.com> Signed-off-by: Kaonan Micadei <k.micadei@gmail.com> Signed-off-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Signed-off-by: Kaonan Micadei <kaonan.micadei@pasqal.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com> Co-authored-by: Kaonan Micadei <kaosmicadei@users.noreply.github.com> Co-authored-by: Kaonan Micadei <k.micadei@gmail.com> Co-authored-by: Kaonan Micadei <kaonan.micadei@pasqal.com> Co-authored-by: Pradnya Khalate <pkhalate@nvidia.com> Co-authored-by: Pradnya Khalate <148914294+khalatepradnya@users.noreply.github.com>
szilveszteri
pushed a commit
that referenced
this pull request
Apr 1, 2025
* Added support for local pipeline development * Changed device pass pipeline for remote execution * Fixed pipeline logic for development
szilveszteri
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the if else statement added all the changes are formatting done automatically