Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) #5706

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Backmerge: #5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) #5706

merged 2 commits into from
Oct 10, 2024

Conversation

mnmsvlw
Copy link
Collaborator

@mnmsvlw mnmsvlw commented Oct 9, 2024

#5651 - The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead)

#5652 - Export to SDF V3000 returns SDF V2000

#5653 - The reaction can't save to MOL V3000 (returns MOL V2000 instead)

How the feature works? / How did you fix the issue?

This PR updates Ketcher to pass the molfile-saving-mode option to Indigo

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

This was linked to issues Oct 9, 2024
The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) #5651
Closed
Export to SDF V3000 returns SDF V2000 #5652
Closed
The reaction can't save to MOL V3000 (returns MOL V2000 instead) #5653
Closed
@NataliaLoginova NataliaLoginova merged commit cb22a2f into master Oct 10, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 5651-the-reaction-cant-save-to-mdl-rxn-v3000-returns-rxn-v2000-instead branch October 10, 2024 17:33
@NataliaLoginova NataliaLoginova changed the title #5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) Backmerge: #5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) Oct 11, 2024
rrodionov91 pushed a commit that referenced this pull request Oct 13, 2024
@mnmsvlw @rrodionov91
#5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 i…
dcb21b5 
…nstead) (#5706)

* #5651 - Add support for MOL V3000, SDF V3000, MDL RXN V3000 on structure save

* Update tests
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@mnmsvlw @Guch1g0v
#5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 i…
122182e 
…nstead) (#5706)

* #5651 - Add support for MOL V3000, SDF V3000, MDL RXN V3000 on structure save

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@svvald svvald svvald approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

Assignees

@mnmsvlw mnmsvlw

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mnmsvlw @svvald @NataliaLoginova