Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to SDF V3000 returns SDF V2000 #5652

Closed
AlexeyGirin opened this issue Oct 3, 2024 · 2 comments · Fixed by #5706 or #5715
Closed

Export to SDF V3000 returns SDF V2000 #5652

AlexeyGirin opened this issue Oct 3, 2024 · 2 comments · Fixed by #5706 or #5715
Assignees
@mnmsvlw
Labels
bug Export to SDF Bucket: Bugs related to Export to SDF Priority: High regression Issue was found during regression
Milestone
Ketcher 2.26.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 3, 2024 •
edited
Loading

Reproduced on 2.26
As per @AliaksandrDziarkach this is because Ketcher doesn't pass version to Indigo

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Load from file: one-attachment-point-added-in-micro-mode.zip
    image
  3. Export canvas to SDF V3000

Actual behavior
System returns content in SDF V2000 format
image
ActualResult.zip

Expected behavior
System returns content in SDF V3000 format
image
ExpectedResult.zip

Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-10-03; 12:06:08
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added bug regression Issue was found during regression Priority: High Export to SDF Bucket: Bugs related to Export to SDF labels Oct 3, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/Indigo Oct 7, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 7, 2024 •
edited
Loading

Please, pay attention, that we have the same problem for RDF V3000, it should be fixed as well:
image

Environment Details:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:45:04
  • Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)

@mnmsvlw mnmsvlw self-assigned this Oct 8, 2024
@NataliaLoginova NataliaLoginova removed their assignment Oct 8, 2024
@mnmsvlw mnmsvlw mentioned this issue Oct 9, 2024
Merged
9 tasks
@mnmsvlw mnmsvlw linked a pull request Oct 9, 2024 that will close this issue
Backmerge: #5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) #5706
Merged
9 tasks
@mnmsvlw mnmsvlw mentioned this issue Oct 10, 2024
Merged
9 tasks
@mnmsvlw mnmsvlw linked a pull request Oct 10, 2024 that will close this issue
#5651 – The reaction can't save to MDL RXN V3000 (returns RXN V2000 instead) #5715
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
bug Export to SDF Bucket: Bugs related to Export to SDF Priority: High regression Issue was found during regression
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
4 participants
@NataliaLoginova @AlexeyGirin @mnmsvlw @ivanmaslow