Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout for pathway reaction on canvas #2309

Closed
yauhen-karmyzau opened this issue Sep 4, 2024 · 2 comments · Fixed by #2439
Closed

Update layout for pathway reaction on canvas #2309

yauhen-karmyzau opened this issue Sep 4, 2024 · 2 comments · Fixed by #2439
Assignees
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes

Comments

@yauhen-karmyzau
Copy link
Collaborator

yauhen-karmyzau commented Sep 4, 2024

Building pathway reactions, we align arrow's starting points vertically:
Image

Pathway reaction layout should be updated to meet the following requirements:

  1. Single arrow type should be changed to have the same style head arrow, as we use for multi-tailed arrows.
  2. Pathway reaction should be divided into sections and each element should be centred in the section.
  3. Margin between sections must be equal to reaction-component-margin-size (distance between an arrow's right/left point and closest bond of the widest molecule in right/left columns).
  4. Section width must be equal to the widest molecule in the section.
  5. Multi-tailed arrows' and single arrows' start and and points must be aligned vertically in a section as well.
  6. Default size of arrows in a pathway reaction must be changed:
    1. Head arrow's line must be 6.5 default sizes of the bond
      Image

Image

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 8, 2024

Tested in scope of Load RDF task, for more details check comments here - #2102, cascade reactions are displayed with correct alignment and filled arrow style.
2 defects are detected, they should be retested after fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants