Merged
Conversation
grawity
reviewed
Dec 31, 2018
src/mpDris2.in.py
Outdated
| else: | ||
| logger.error("Failed to init libnotify; disabling notifications") | ||
| self._notification = None | ||
| def _init(self, params): |
Collaborator
There was a problem hiding this comment.
Technically I think it's fine to just early-return from __init__(), although I guess a separate function adds clarity.
grawity
approved these changes
Dec 31, 2018
Before initializing notifications check that org.freedesktop.Notifications is available on the bus. Refs #109
eonpatapon
force-pushed
the
check-notifications
branch
from
7d88179 to
1923305
Compare
|
This broke the systemd user unit on AwesomeWM. :( |
Collaborator
You'll have to provide more details than that. Please open a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before initializing notifications check that
org.freedesktop.Notifications is available on the bus.
Refs #109