Skip to content

Comments

Add option to disable notification at startup#109

Closed
AndreaOrru wants to merge 1 commit intoeonpatapon:masterfrom
AndreaOrru:master
Closed

Add option to disable notification at startup#109
AndreaOrru wants to merge 1 commit intoeonpatapon:masterfrom
AndreaOrru:master

Conversation

@AndreaOrru
Copy link

Added a notify_startup option to the configuration file (defaults to True).

@eonpatapon
Copy link
Owner

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Is it disturbing for you?

@grawity
Copy link
Collaborator

grawity commented Dec 28, 2018

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Hmm, that could be done quietly using GetNameOwner() instead.

(If you want to check whether there's an activatable service that provides o.f.Notifications, there are ListActivatableNames() or StartServiceByName(), but it's probably not a good idea to rely on auto-activation for such "multiple provider" names in the first place.)

@eonpatapon
Copy link
Owner

@grawity I will try to use GetNameOwner() instead then

eonpatapon added a commit that referenced this pull request Dec 31, 2018
Before initializing notifications check that
org.freedesktop.Notifications is available on the bus.

Refs #109
@AndreaOrru
Copy link
Author

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Is it disturbing for you?

Not massively, but I would prefer not to have it :)
Feel free to close this PR if the other one addresses the problem.

Thank you!

eonpatapon added a commit that referenced this pull request Jan 2, 2019
Before initializing notifications check that
org.freedesktop.Notifications is available on the bus.

Refs #109
@eonpatapon
Copy link
Owner

Thanks, other PR is merged

@eonpatapon eonpatapon closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants