Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors Reconciler() Method for Kubernetes Provider #803

Closed
wants to merge 1 commit into from

Conversation

danehans
Copy link
Contributor

Refactors Kubernetes controller:

  • Improves readability.
  • Improves log messages.
  • Updates the reconciler to continue processing a request even if dependent resources cannot be found.

Fixes #788

Signed-off-by: danehans daneyonhansen@gmail.com

Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans danehans requested a review from a team as a code owner December 12, 2022 23:02
@danehans danehans added this to the 0.3.0-rc.1 milestone Dec 12, 2022
@danehans
Copy link
Contributor Author

cc: @chauhanshubham

@codecov-commenter
Copy link

Codecov Report

Merging #803 (84e720d) into main (fbc55a3) will increase coverage by 0.71%.
The diff coverage is 69.67%.

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   61.06%   61.77%   +0.71%     
==========================================
  Files          46       46              
  Lines        5674     6023     +349     
==========================================
+ Hits         3465     3721     +256     
- Misses       1980     2068      +88     
- Partials      229      234       +5     
Impacted Files Coverage Δ
internal/cmd/server.go 7.82% <0.00%> (-0.07%) ⬇️
internal/gatewayapi/runner/runner.go 31.32% <0.00%> (-1.59%) ⬇️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/ir/infra.go 67.41% <ø> (ø)
internal/ir/xds.go 76.82% <ø> (ø)
internal/message/types.go 0.00% <ø> (ø)
internal/provider/kubernetes/routes.go 57.74% <0.00%> (ø)
internal/provider/kubernetes/controller.go 50.09% <20.23%> (-0.01%) ⬇️
internal/gatewayapi/helpers_v1alpha2.go 27.77% <33.33%> (+7.14%) ⬆️
internal/gatewayapi/contexts.go 75.94% <72.15%> (-1.22%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans
Copy link
Contributor Author

This PR is required to enable the HTTPRouteReferenceGrant conformance test.

@danehans danehans marked this pull request as draft December 14, 2022 18:42
@danehans
Copy link
Contributor Author

Superseded by #793

@danehans danehans closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backendref service not found causes xds no message received
2 participants