Add ReferenceGrant Support for Routes #793
Conversation
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 62.01% 62.05% +0.03%
==========================================
Files 46 46
Lines 5995 5993 -2
==========================================
+ Hits 3718 3719 +1
+ Misses 2043 2041 -2
+ Partials 234 233 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danehans
changed the title
danehans
changed the title
danehans
added
provider/kubernetes
|
xref #780 for adding add'l conformance tests. |
| refGrant, err := r.findReferenceGrant(ctx, from, to) | ||
| if err != nil { | ||
| r.log.Error(err, "unable to find ReferenceGrant that links the Secret to Gateway") | ||
| continue | ||
| r.log.Error(err, "failed to find ReferenceGrant") |
There was a problem hiding this comment.
nit, can we add some more info here to difference which exact refgrant was not found
There was a problem hiding this comment.
nvm, please ignore, looks like the callee function is printing out the details so prob not needed here
There was a problem hiding this comment.
I've moved the log message to the calling func.
| r.log.Info("failed to find Service", "namespace", serviceNamespaceName.Namespace, | ||
| "name", serviceNamespaceName.Name, "error", err) | ||
| } else { | ||
| return reconcile.Result{}, err |
There was a problem hiding this comment.
shouldnt this return be removed as well ?
There was a problem hiding this comment.
Good catch. Yes, commit 365610b fixes this.
Signed-off-by: danehans <daneyonhansen@gmail.com>
Enables `HTTPRoutePartiallyInvalidViaInvalidReferenceGrant` Fixed by envoyproxy#793 Closes envoyproxy#781 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Previously, a route, e.g. HTTPRoute, could not reference a backend in a different namespace due to
validateBackendRef()returning an error if a BackendRef included thenamespacefield.Reconcile()to only add a RefereneGrant to the resource tree if the RefereneGrant can be found and only return an error if an error was received when listing RefereneGrants.Reconcile()to only add s Service to the resource tree if the Service can be found and only return an error if an error was received when Getting the Service.validateBackendRef()to no longer return an error if thenamespacefield is set for a backendRef.HTTPRouteReferenceGrantconformance test.Fixes #792
Fixes #788
Fixes #545
Signed-off-by: danehans daneyonhansen@gmail.com