-
Notifications
You must be signed in to change notification settings - Fork 596
change process GVK for TLSRoute/BackendTLSPolicy #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7523 +/- ##
==========================================
+ Coverage 72.33% 72.35% +0.01%
==========================================
Files 232 232
Lines 34109 34118 +9
==========================================
+ Hits 24674 24685 +11
Misses 7664 7664
+ Partials 1771 1769 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ec1a42 to
6ef897d
Compare
2dceab3 to
05f0125
Compare
|
Thanks @zirain for fixing this. Could this happen again next time when we upgrade Gateway API? Is there anything that we can do to prevent it in the future-and upgrade test? |
05f0125 to
134bde6
Compare
we should be careful with the verions that EG supported. |
134bde6 to
853ad46
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
853ad46 to
2e8fe19
Compare
fixes: #7522
related to: #7090
For TLSRoute, use v1alpha2.
For BackendTLSPolicy, use v1alpha3.
The goal is make
EG v1.6+work withGateway API v1.3this's important during the upgrade.