Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Nov 15, 2025

fixes: #7522

related to: #7090

For TLSRoute, use v1alpha2.
For BackendTLSPolicy, use v1alpha3.

The goal is make EG v1.6+ work with Gateway API v1.3 this's important during the upgrade.

@zirain zirain requested a review from a team as a code owner November 15, 2025 09:00
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 63.75000% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.35%. Comparing base (6a99849) to head (2e8fe19).

Files with missing lines Patch % Lines
internal/provider/kubernetes/status.go 0.00% 10 Missing ⚠️
internal/provider/kubernetes/indexers.go 30.00% 2 Missing and 5 partials ⚠️
internal/provider/kubernetes/status_updater.go 36.36% 7 Missing ⚠️
internal/cmd/egctl/status.go 0.00% 2 Missing ⚠️
internal/provider/kubernetes/controller.go 88.23% 0 Missing and 2 partials ⚠️
internal/provider/kubernetes/predicates.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7523      +/-   ##
==========================================
+ Coverage   72.33%   72.35%   +0.01%     
==========================================
  Files         232      232              
  Lines       34109    34118       +9     
==========================================
+ Hits        24674    24685      +11     
  Misses       7664     7664              
+ Partials     1771     1769       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain force-pushed the support-multiple-gvk branch from 3ec1a42 to 6ef897d Compare November 15, 2025 13:48
@zirain zirain changed the title watch multiple group versions change process GVK for TLSRoute/BackendTLSPolicy Nov 15, 2025
@zirain zirain force-pushed the support-multiple-gvk branch from 2dceab3 to 05f0125 Compare November 16, 2025 12:50
@zhaohuabing
Copy link
Member

zhaohuabing commented Nov 17, 2025

Thanks @zirain for fixing this. Could this happen again next time when we upgrade Gateway API? Is there anything that we can do to prevent it in the future-and upgrade test?

@zirain zirain force-pushed the support-multiple-gvk branch from 05f0125 to 134bde6 Compare November 17, 2025 03:37
@zirain
Copy link
Member Author

zirain commented Nov 17, 2025

@zirain
Copy link
Member Author

zirain commented Nov 17, 2025

Thanks @zirain for fixing this. Could this happen again next time when we upgrade Gateway API? Is there anything that we can do to prevent it in the future-and upgrade test?

we should be careful with the verions that EG supported.

@zirain zirain force-pushed the support-multiple-gvk branch from 134bde6 to 853ad46 Compare November 20, 2025 02:08
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the support-multiple-gvk branch from 853ad46 to 2e8fe19 Compare November 20, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support both v1alpha3 and v1 Gateway API

3 participants