Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Sep 29, 2025

xref: #7042

Key changes:

  • move the use v1 struct as much as possible
  • TLSRoute now use v1alpha3 as storage version

@zirain zirain requested a review from a team as a code owner September 29, 2025 04:17
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain changed the title chore: bump Gateway API to v1.4.0-rc.1 chore: bump Gateway API to v1.4.0-rc.2 Sep 30, 2025
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 71.62791% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.93%. Comparing base (d7d599a) to head (ce0943b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/conformance/suite.go 0.00% 18 Missing ⚠️
internal/provider/kubernetes/status.go 0.00% 7 Missing and 6 partials ⚠️
internal/provider/kubernetes/indexers.go 30.00% 2 Missing and 5 partials ⚠️
internal/provider/kubernetes/controller.go 66.66% 4 Missing and 2 partials ⚠️
internal/provider/kubernetes/status_updater.go 0.00% 6 Missing ⚠️
internal/cmd/egctl/status.go 0.00% 2 Missing ⚠️
internal/gatewayapi/backendtrafficpolicy.go 71.42% 2 Missing ⚠️
internal/gatewayapi/envoyextensionpolicy.go 60.00% 2 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 2 Missing ⚠️
internal/gatewayapi/securitypolicy.go 80.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7090      +/-   ##
==========================================
- Coverage   70.96%   70.93%   -0.03%     
==========================================
  Files         229      229              
  Lines       41012    41032      +20     
==========================================
+ Hits        29106    29108       +2     
- Misses      10190    10207      +17     
- Partials     1716     1717       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zirain added 3 commits October 2, 2025 01:46
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain changed the title chore: bump Gateway API to v1.4.0-rc.2 feat: bump Gateway API to v1.4.0-rc.2 Oct 2, 2025
zirain added 2 commits October 2, 2025 17:23
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
name: backend-tls-ca
namespace: gateway-conformance-infra
---
# keep this v1alpha3 to verify EG worked for both v1alpha3 and v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @arkodg

@zirain
Copy link
Member Author

zirain commented Oct 7, 2025

/retest

zirain added 5 commits October 9, 2025 20:09
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Member Author

zirain commented Oct 10, 2025

/retest

arkodg
arkodg previously approved these changes Oct 18, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 18, 2025 01:11
rudrakhp
rudrakhp previously approved these changes Oct 18, 2025
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
@rudrakhp rudrakhp dismissed stale reviews from arkodg and themself via ce0943b October 18, 2025 03:41
@rudrakhp rudrakhp enabled auto-merge (squash) October 18, 2025 03:45
@rudrakhp
Copy link
Member

/retest

@rudrakhp rudrakhp merged commit 1ea8d96 into envoyproxy:main Oct 18, 2025
82 of 86 checks passed
@zirain zirain deleted the bump-gatewayapi branch October 18, 2025 06:16
aburan28 pushed a commit to aburan28/gateway that referenced this pull request Oct 18, 2025
* chore: bump Gateway API to v1.4.0-rc.1

Signed-off-by: zirain <zirain2009@gmail.com>

* bump to rc.2

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* fix gen

Signed-off-by: zirain <zirain2009@gmail.com>

* skip BackendTLSPolicyInvalidCACertificateRef

Signed-off-by: zirain <zirain2009@gmail.com>

* skip BackendTLSPolicyInvalidKind

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* skip

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test and skip more

Signed-off-by: zirain <zirain2009@gmail.com>

* fix cmp.Equal

Signed-off-by: zirain <zirain2009@gmail.com>

* skip TLSRoute tests

Signed-off-by: zirain <zirain2009@gmail.com>

* fix

Signed-off-by: zirain <zirain2009@gmail.com>

* golint integration

Signed-off-by: zirain <zirain2009@gmail.com>

* skip UDPRoute

Signed-off-by: zirain <zirain2009@gmail.com>

* use gwapiv1a3.TLSRoute

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* use gwapiv1.BackendTLSPolicy and fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

* fix e2e

Signed-off-by: zirain <zirain2009@gmail.com>

* enable UDPRoute

Signed-off-by: zirain <zirain2009@gmail.com>

* fix e2e

Signed-off-by: zirain <zirain2009@gmail.com>

* revert

Signed-off-by: zirain <zirain2009@gmail.com>

* skip on dual

Signed-off-by: zirain <zirain2009@gmail.com>

* fix merge

Signed-off-by: zirain <zirain2009@gmail.com>

* bump v1.4.0

Signed-off-by: zirain <zirain2009@gmail.com>

* revert to v1alpha3

Signed-off-by: zirain <zirain2009@gmail.com>

* fix gen

Signed-off-by: zirain <zirain2009@gmail.com>

* fix after merge

Signed-off-by: zirain <zirain2009@gmail.com>

* use v1

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants