-
Notifications
You must be signed in to change notification settings - Fork 606
feat: support ir metadata to tcproute/udproute #6815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37c5380 to
d495491
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6815 +/- ##
==========================================
- Coverage 71.05% 71.02% -0.03%
==========================================
Files 225 225
Lines 39973 39963 -10
==========================================
- Hits 28401 28384 -17
- Misses 9897 9903 +6
- Partials 1675 1676 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d495491 to
2eeaae9
Compare
2eeaae9 to
fde62d2
Compare
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
fde62d2 to
4d34038
Compare
|
@kkk777-7 can you rebase and fix the |
4d34038 to
e455218
Compare
|
another ci failed : |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
e455218 to
4543c37
Compare
|
/retest |
1 similar comment
|
/retest |
What this PR does / why we need it:
Add IR metadata to tcproute/udproute.
BackendTrafficPolicy supports attaching to tcproute/udproute.
Section name info is required when supporting section targeting (Gateway Listener / Route Rule) in BackendTrafficPolicy.
Section name metadata is used to identify the target listener or route rule for applying the policy.
e.g. https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/envoyextensionpolicy.go#L492
Related Issue : #6607
Which issue(s) this PR fixes:
Fixes #
Release Notes: No