Skip to content

Conversation

@kkk777-7
Copy link
Member

@kkk777-7 kkk777-7 commented Aug 18, 2025

What this PR does / why we need it:
Add IR metadata to tcproute/udproute.

BackendTrafficPolicy supports attaching to tcproute/udproute.
Section name info is required when supporting section targeting (Gateway Listener / Route Rule) in BackendTrafficPolicy.
Section name metadata is used to identify the target listener or route rule for applying the policy.
e.g. https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/envoyextensionpolicy.go#L492

Related Issue : #6607

Which issue(s) this PR fixes:

Fixes #

Release Notes: No

@kkk777-7 kkk777-7 requested a review from a team as a code owner August 18, 2025 18:03
@kkk777-7 kkk777-7 force-pushed the support-ir-metadata-xroute branch from 37c5380 to d495491 Compare August 24, 2025 09:14
@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.02%. Comparing base (e4a3069) to head (9c66a4b).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6815      +/-   ##
==========================================
- Coverage   71.05%   71.02%   -0.03%     
==========================================
  Files         225      225              
  Lines       39973    39963      -10     
==========================================
- Hits        28401    28384      -17     
- Misses       9897     9903       +6     
- Partials     1675     1676       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

arkodg
arkodg previously approved these changes Sep 9, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team September 9, 2025 16:29
@arkodg arkodg added this to the v1.6.0-rc.1 Release milestone Sep 9, 2025
zirain
zirain previously approved these changes Sep 10, 2025
@zirain zirain force-pushed the support-ir-metadata-xroute branch from fde62d2 to 4d34038 Compare September 10, 2025 01:23
@zirain
Copy link
Member

zirain commented Sep 10, 2025

@kkk777-7 can you rebase and fix the gen-check?

@kkk777-7 kkk777-7 dismissed stale reviews from zirain and arkodg via e455218 September 10, 2025 04:49
@kkk777-7 kkk777-7 force-pushed the support-ir-metadata-xroute branch from 4d34038 to e455218 Compare September 10, 2025 04:49
@kkk777-7
Copy link
Member Author

@zirain
thanks for reply!
fixed deprecated GetRouteType function. (commit: e455218)
This seemed to have occurred due to parallel changes in the following PRs.
#6820
#6875

@kkk777-7
Copy link
Member Author

another ci failed : --- FAIL: TestProvider (11.72s)
I’ll take a look after work.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@zirain zirain force-pushed the support-ir-metadata-xroute branch from e455218 to 4543c37 Compare September 10, 2025 06:24
@kkk777-7
Copy link
Member Author

/retest

1 similar comment
@kkk777-7
Copy link
Member Author

/retest

@arkodg arkodg requested a review from zirain September 10, 2025 18:43
@arkodg arkodg requested review from a team September 11, 2025 01:06
@zirain zirain merged commit 7cf6bc9 into envoyproxy:main Sep 15, 2025
49 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants