feat(securitypolicy): Update GatewayAPI to support tcp security policy #7171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king down larger pr's in to smaller ones Signed-off-by: davem-git <demathieu@gmail.com>
… Breaking down larger pr's in to smaller ones Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
…curity-policy-api
…s clientIP and what defines a clientIP Signed-off-by: davem-git <demathieu@gmail.com>
…ateway into feat-tcp-security-policy-api
…curity-policy-gateway-api
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
Signed-off-by: davem-git <demathieu@gmail.com>
…ateway into feat-tcp-security-policy-api
Signed-off-by: davem-git <demathieu@gmail.com>
Signed-off-by: davem-git <demathieu@gmail.com>
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
…ty security policies, but that was determined as fine so the check to block it was removed Signed-off-by: davem-git <demathieu@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7171 +/- ##
==========================================
+ Coverage 71.04% 71.08% +0.03%
==========================================
Files 229 229
Lines 41099 41164 +65
==========================================
+ Hits 29198 29260 +62
- Misses 10181 10184 +3
Partials 1720 1720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
…ateway into feat-tcp-security-policy-gateway-api
davem-git
force-pushed
the
feat-tcp-security-policy-gateway-api
branch
from
3a2057e to
67814ea
Compare
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
Signed-off-by: davem-git <demathieu@gmail.com>
Signed-off-by: davem-git <demathieu@gmail.com>
kkk777-7
previously approved these changes
Oct 17, 2025
Member
|
LGTM thanks! |
Member
|
/retest |
arkodg
reviewed
Oct 18, 2025
…curity-policy-gateway-api
…curity-policy-gateway-api
Signed-off-by: davem-git <demathieu@gmail.com>
davem-git
force-pushed
the
feat-tcp-security-policy-gateway-api
branch
from
85d61b6 to
6753bca
Compare
…curity-policy-gateway-api
Contributor
Author
|
Fixed a test that was still referencing alpha2, which was removed in this PR. Sorry about that. The update cleared existing approvals. |
Contributor
Author
|
the coverage test seems like a network timeout failure |
…curity-policy-gateway-api
kkk777-7
previously approved these changes
Oct 21, 2025
arkodg
reviewed
Oct 21, 2025
| for _, listener := range parentRefCtx.listeners { | ||
| irListener := xdsIR[irKey].GetHTTPListener(irListenerName(listener)) | ||
| if irListener != nil { | ||
| switch route.GetRouteType() { |
Contributor
There was a problem hiding this comment.
curious why this code is needed when its NA for TCPRoute, which is checked in validateSecurityPolicyForTCP
Contributor
Author
There was a problem hiding this comment.
which part are you referring to, why we do switch.route? TCP is applied differently with expectedTCPRouteName := strings.TrimSuffix(prefix, "/") , but i don't see that getting applied just continueing if it doesn't match
then there's this line
if target.SectionName != nil && string(*target.SectionName) != r.Destination.Metadata.SectionName {
continue
}```
vs this one for httproute
```go
if target.SectionName != nil && string(*target.SectionName) != r.Metadata.SectionName {
continue
}those have to be different.
let me see if i can reduce the difference
Signed-off-by: davem-git <demathieu@gmail.com>
…curity-policy-gateway-api
zhaohuabing
approved these changes
Oct 22, 2025
…curity-policy-gateway-api
davem-git
force-pushed
the
feat-tcp-security-policy-gateway-api
branch
from
7a6f78a to
7e601e5
Compare
linmosko
pushed a commit
to linmosko/gateway
that referenced
this pull request
Oct 27, 2025
envoyproxy#7171) * feat(securitypolicy): Update API to support tcp security policy. Breaking down larger pr's in to smaller ones Signed-off-by: davem-git <demathieu@gmail.com> Signed-off-by: Lin Moskovitch <lin.moskovitch@sap.com>
ekline-ai
pushed a commit
to ekline-ai/envoyproxy-gateway
that referenced
this pull request
Nov 2, 2025
envoyproxy#7171) * feat(securitypolicy): Update API to support tcp security policy. Breaking down larger pr's in to smaller ones Signed-off-by: davem-git <demathieu@gmail.com> Signed-off-by: EkLine AI <ekline-ai@ekline.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##4908
Release Notes: Yes/No
No