Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use net.JoinHostPort #4599

Merged
merged 3 commits into from
Nov 1, 2024
+23 −18
Merged

chore: use net.JoinHostPort #4599

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f065f5
chore: use net.JoinHostPort
zirain Oct 31, 2024
c1c0a04
more fix
zirain Oct 31, 2024
9ac2399
remove netutils.JoinHostPort
zirain Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/e2e/tests/ratelimit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ package tests

import (
"context"
"fmt"
"net"
"testing"
"time"
Expand Down Expand Up @@ -495,7 +494,7 @@ var RateLimitMultipleListenersTest = suite.ConformanceTest{

gwPorts := []string{"80", "8080"}
for _, port := range gwPorts {
gwAddr = fmt.Sprintf("%s:%s", gwIP, port)
gwAddr = net.JoinHostPort(gwIP, port)

ratelimitHeader := make(map[string]string)
expectOkResp := http.ExpectedResponse{
Expand Down