chore: use net.JoinHostPort #4599
Open
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
previously approved these changes
Oct 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4599 +/- ##
==========================================
+ Coverage 65.40% 65.42% +0.01%
==========================================
Files 211 211
Lines 31887 31887
==========================================
+ Hits 20855 20861 +6
+ Misses 9785 9781 -4
+ Partials 1247 1245 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <zirain2009@gmail.com>
qicz
approved these changes
Oct 31, 2024
zhaohuabing
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4597