Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listener on IPv6 first cluster #4573

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1,732 −125

change to localhost

5c4e99b
Select commit
Loading
Failed to load commit list.
Open

fix: listener on IPv6 first cluster #4573

change to localhost
5c4e99b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

65.38% (target 60.00%)

View this Pull Request on Codecov

65.38% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 81.17647% with 16 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (bb3bbdb) to head (5c4e99b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/utils/net/ip.go 73.68% 4 Missing and 1 partial ⚠️
internal/xds/translator/listener.go 85.18% 3 Missing and 1 partial ⚠️
internal/gatewayapi/listener.go 57.14% 2 Missing and 1 partial ⚠️
internal/cmd/envoy/shutdown_manager.go 0.00% 2 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 1 Missing ⚠️
internal/infrastructure/host/proxy_infra.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4573      +/-   ##
==========================================
- Coverage   65.47%   65.38%   -0.09%     
==========================================
  Files         211      212       +1     
  Lines       31854    31930      +76     
==========================================
+ Hits        20855    20878      +23     
- Misses       9754     9804      +50     
- Partials     1245     1248       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov