fix: listener on IPv6 first cluster #4573
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
==========================================
- Coverage 65.47% 65.38% -0.09%
==========================================
Files 211 212 +1
Lines 31854 31930 +76
==========================================
+ Hits 20855 20878 +23
- Misses 9754 9804 +50
- Partials 1245 1248 +3 ☔ View full report in Codecov by Sentry. |
| @@ -46,6 +46,10 @@ spec: | |||
| - server | |||
| - --config-path=/config/envoy-gateway.yaml | |||
| env: | |||
| - name: POD_IP | |||
There was a problem hiding this comment.
its a little fragile to use Envoy Gateway IP type to determine IP type for Envoy Proxy.
instead can we add the env to Envoy Proxy
There was a problem hiding this comment.
does envoy support something like ${POD_IP} and check the POD_IP and change the listener address to ::1?
There was a problem hiding this comment.
yeah, chatgpt says yes, instead of listening on 0.0.0.0 or ::, you could listen on ${POD_IP}
There was a problem hiding this comment.
I can give a try, and we need POD_IP for dynamic listener.
There was a problem hiding this comment.
maybe I'm not smart as gpt, but envoy report error with malformed IP address: ${POD_IP}.
Signed-off-by: zirain <zirain2009@gmail.com>
| if resp, err := http.Post(fmt.Sprintf("http://%s:%d/%s", | ||
| bootstrap.EnvoyAdminAddress, bootstrap.EnvoyAdminPort, path), "application/json", nil); err != nil { | ||
| bootstrap.AdminAddress(egv1a1.IPv4), bootstrap.EnvoyAdminPort, path), "application/json", nil); err != nil { |
There was a problem hiding this comment.
this may not right, what about change it to localhost? cc @arkodg @zhaohuabing
Signed-off-by: zirain <zirain2009@gmail.com>
fix: #4565
xref: #4572
Separate from : #4550
::instead of0.0.0.0when IPv6 first.