helm: make eg-addons support IPv6 cluster #4559
Merged
+77
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test on my linux(IPv6 kind cluster) and macos m1(IPv4 kind cluster), full test will be inhttps://github.com//pull/4550. Split from #4550 because #4550 still need wait envoyproxy/ratelimit#748. |
zhaohuabing
reviewed
Oct 29, 2024
internal/gatewayapi/testdata/securitypolicy-with-jwt-and-invalid-oidc.out.yaml
Outdated
Show resolved
Hide resolved
zhaohuabing
reviewed
Oct 29, 2024
zhaohuabing
reviewed
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4559 +/- ##
==========================================
- Coverage 65.60% 65.48% -0.12%
==========================================
Files 211 211
Lines 31696 31858 +162
==========================================
+ Hits 20793 20862 +69
- Misses 9698 9753 +55
- Partials 1205 1243 +38 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
otel-collector-ipv6
branch
from
6cb142e
to
89fa2ad
Compare
arkodg
reviewed
Oct 29, 2024
| service: | ||
| telemetry: | ||
| metrics: | ||
| address: "[${env:MY_POD_IP}]:8888" |
There was a problem hiding this comment.
who is populating this env ?
There was a problem hiding this comment.
we'd better change upstream charts, I do believe they should change the default value.
arkodg
approved these changes
Oct 29, 2024
zhaohuabing
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #4550 (comment)