Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): Implement Retry in BTP #2678

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Feb 22, 2024

What this PR does / why we need it:
Implements retry API in BTP: #2657

Which issue(s) this PR fixes:
Fixes #1907

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner February 22, 2024 20:13
Signed-off-by: Guy Daich <guy.daich@sap.com>
routes:
- name: "first-route"
hostname: "*"
retry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add another case with a empty retry: {} to its easier to cross check defaults in the future, thanks

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 63.24111% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 63.37%. Comparing base (fc7d6bc) to head (74df8ed).

Files Patch % Lines
internal/ir/zz_generated.deepcopy.go 0.00% 85 Missing and 1 partial ⚠️
internal/xds/translator/route.go 92.04% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2678      +/-   ##
==========================================
+ Coverage   63.33%   63.37%   +0.03%     
==========================================
  Files         119      119              
  Lines       19211    19464     +253     
==========================================
+ Hits        12168    12336     +168     
- Misses       6244     6328      +84     
- Partials      799      800       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc
Copy link
Contributor Author

guydc commented Feb 23, 2024

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@guydc guydc added this to the v1.0.0-rc1 milestone Feb 23, 2024
@arkodg arkodg requested review from a team February 23, 2024 02:15
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@arkodg arkodg merged commit d407e0f into envoyproxy:main Feb 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Support retries
3 participants