feat(translator): Implement Retry in BTP #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
impl-btp-retries
branch
from
7213f17
to
30fcf6b
Compare
arkodg
reviewed
Feb 22, 2024
| routes: | ||
| - name: "first-route" | ||
| hostname: "*" | ||
| retry: |
There was a problem hiding this comment.
can we add another case with a empty retry: {} to its easier to cross check defaults in the future, thanks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2678 +/- ##
==========================================
+ Coverage 63.33% 63.37% +0.03%
==========================================
Files 119 119
Lines 19211 19464 +253
==========================================
+ Hits 12168 12336 +168
- Misses 6244 6328 +84
- Partials 799 800 +1 ☔ View full report in Codecov by Sentry. |
|
/retest |
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements retry API in BTP: #2657
Which issue(s) this PR fixes:
Fixes #1907