-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support retry on in BackendTrafficPolicy #2657
Conversation
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 63.36% 63.36%
=======================================
Files 119 119
Lines 19234 19234
=======================================
Hits 12187 12187
Misses 6233 6233
Partials 814 814 ☔ View full report in Codecov by Sentry. |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
What this PR does / why we need it:
api: support retry on in BackendTrafficPolicy
Relates to #1821, #1907
Continue work by @tmsnan in #2168