Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support retry on in BackendTrafficPolicy #2657

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Feb 20, 2024

What this PR does / why we need it:
api: support retry on in BackendTrafficPolicy

Relates to #1821, #1907

Continue work by @tmsnan in #2168

tmsnan and others added 7 commits January 11, 2024 10:43
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: nan zhao <tmsnan94@outlook.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner February 20, 2024 01:25
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (579b3b4) 63.36% compared to head (7aa8849) 63.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   63.36%   63.36%           
=======================================
  Files         119      119           
  Lines       19234    19234           
=======================================
  Hits        12187    12187           
  Misses       6233     6233           
  Partials      814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc
Copy link
Contributor Author

guydc commented Feb 20, 2024

/retest

@guydc
Copy link
Contributor Author

guydc commented Feb 20, 2024

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from zhaohuabing and a team February 20, 2024 19:15
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zhaohuabing zhaohuabing merged commit 4c79ef9 into envoyproxy:main Feb 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants