Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default LB Policy to Least Request #1901

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Sep 19, 2023

@arkodg arkodg requested a review from a team as a code owner September 19, 2023 20:33
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1901 (b8bdf77) into main (b98c1d1) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
- Coverage   66.16%   66.13%   -0.04%     
==========================================
  Files          86       86              
  Lines       12876    12876              
==========================================
- Hits         8519     8515       -4     
- Misses       3831     3833       +2     
- Partials      526      528       +2     
Files Changed Coverage Δ
internal/xds/translator/cluster.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should mention this in release notes.

@arkodg arkodg added the release-note Indicates a required release note label Sep 20, 2023
@arkodg arkodg requested review from a team, kflynn, LanceEa and chauhanshubham and removed request for a team September 20, 2023 06:32
@zirain zirain merged commit 1796347 into envoyproxy:main Sep 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Indicates a required release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants