Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: LoadbalancingPolicy #1105

Closed
arkodg opened this issue Mar 6, 2023 · 5 comments · Fixed by #2063
Closed

proposal: LoadbalancingPolicy #1105

arkodg opened this issue Mar 6, 2023 · 5 comments · Fixed by #2063
Assignees
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Mar 6, 2023

Description:
Allow the user to specify Load Balancing policies to load balance requests from the gateway to the upstream.

[optional Relevant Links:]
Relates to kubernetes-sigs/gateway-api#1778

Currently the requests are being load balanced at an L3 / kube-proxy level since requests are being sent to the Cluster IP of the Service. We need to route to the endpoints directly with #35

@arkodg arkodg added the kind/enhancement New feature or request label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Apr 5, 2023
@qicz qicz removed the stale label May 5, 2023
@qicz
Copy link
Member

qicz commented May 5, 2023

should we provide the global locadbalancing policy in envoyproxy API?

@arkodg
Copy link
Contributor Author

arkodg commented Jun 1, 2023

+1 to adding a global policy in EnvoyProxy, it probably needs to be done in a way that it can be overridden per Backend

arkodg added a commit to arkodg/gateway that referenced this issue Jun 3, 2023
* Allows the user to configure a global load balancing strategy
for the envoy proxy data plane

```
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: set-lb-strategy
spec:
  traffic:
    loadBalancer:
      strategy: LeastRequest
```
* Sets the default load balancing strategy to `LeastRequest` which
will internally set the `WeightedLeastReqquest` knob in Envoy

* Relates to envoyproxy#1256 allowing
the user to fall back to `ClusterIP` style loadbalancing

* Relates to envoyproxy#1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jul 2, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Aug 11, 2023
@github-actions github-actions bot removed the stale label Aug 12, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Sep 11, 2023
arkodg added a commit to arkodg/gateway that referenced this issue Sep 19, 2023
@arkodg arkodg removed the stale label Sep 19, 2023
zirain pushed a commit that referenced this issue Sep 21, 2023
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#weighted-least-request

Relates to #1105

Relevant now that we are introducing multiple endpoints with #1494

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@Xunzhuo Xunzhuo changed the title Support Loadbalancing policies proposal: Loadbalancing policy Sep 22, 2023
@Xunzhuo Xunzhuo changed the title proposal: Loadbalancing policy proposal: Loadbalancing Policy Sep 22, 2023
@Xunzhuo Xunzhuo changed the title proposal: Loadbalancing Policy proposal: LoadbalancePolicy Sep 22, 2023
@Xunzhuo Xunzhuo changed the title proposal: LoadbalancePolicy proposal: LoadbalancingPolicy Sep 22, 2023
@arkodg arkodg self-assigned this Oct 19, 2023
arkodg added a commit to arkodg/gateway that referenced this issue Oct 19, 2023
Relates to envoyproxy#1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this issue Oct 19, 2023
Relates to envoyproxy#1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this issue Oct 20, 2023
* Add LoadBalancer IR to HTTPRoute

Relates to #1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* bump coverage

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this issue Oct 25, 2023
Fixes: envoyproxy#1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this issue Oct 25, 2023
* LoadBalancer in BackendTrafficPolicy

Fixes: #1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain pushed a commit to zirain/gateway that referenced this issue Oct 26, 2023
* LoadBalancer in BackendTrafficPolicy

Fixes: envoyproxy#1105

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants