Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support simple TLS termination #471

Closed
arkodg opened this issue Sep 29, 2022 · 3 comments · Fixed by #519
Closed

Support simple TLS termination #471

arkodg opened this issue Sep 29, 2022 · 3 comments · Fixed by #519
Assignees
@danehans
Labels
kind/enhancement New feature or request provider/kubernetes Issues related to the Kubernetes provider
Milestone
0.2.0

Comments

@arkodg
Copy link
Contributor

arkodg commented Sep 29, 2022

Description:
Add support for HTTPS/TLS termination
Examples shown here https://gateway-api.sigs.k8s.io/v1alpha2/guides/tls/#examples

Looks like most of the work is already done in gateway-api translator

gateway/internal/gatewayapi/translator.go

Line 52 in 8e1e981

Secrets []*v1.Secret
and the provider simply needs to reconcile secrets and pass it over.
@arkodg arkodg added kind/enhancement New feature or request provider/kubernetes Issues related to the Kubernetes provider labels Sep 29, 2022
@arkodg arkodg modified the milestones: 0.3.0, 0.3.0-rc1 Sep 29, 2022
@skriss
Copy link
Contributor

skriss commented Sep 29, 2022

Oof you're right, I was thinking that this was already working end-to-end but yeah the provider is not passing secrets.

@arkodg
Copy link
Contributor Author

arkodg commented Sep 29, 2022

this would have been an easy win for 0.2.0 . This can be considered a bug and added to the 0.2.0 milestone cc @danehans

arkodg added a commit to arkodg/gateway that referenced this issue Sep 30, 2022
@arkodg
xds-translator tests for simple tls
a48a4ee 
Relates to envoyproxy#471

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Sep 30, 2022
Merged
@danehans danehans modified the milestones: 0.3.0-rc1, 0.2.0 Sep 30, 2022
arkodg added a commit to arkodg/gateway that referenced this issue Sep 30, 2022
@arkodg
xds-translator tests for simple tls
c6e34fb 
Relates to envoyproxy#471

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this issue Oct 3, 2022
@arkodg
xds-translator tests for simple tls (#474)
765e14e 
* xds-translator tests for simple tls

Relates to #471

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@danehans danehans self-assigned this Oct 6, 2022
This was referenced Oct 7, 2022
Closed
Merged
Closed
@arkodg
Copy link
Contributor Author

arkodg commented Oct 11, 2022

the TLS termination conformance tests should be incorporated once they are added upstream which is being tracked with kubernetes-sigs/gateway-api#1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danehans danehans

Labels
kind/enhancement New feature or request provider/kubernetes Issues related to the Kubernetes provider
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Adds TLS Termination Support danehans/gateway
3 participants
@danehans @skriss @arkodg