Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A ReferenceGrant Should Be Removed From Watchable Map When UnReferenced #539

Closed
danehans opened this issue Oct 10, 2022 · 4 comments · Fixed by #702
Closed

A ReferenceGrant Should Be Removed From Watchable Map When UnReferenced #539

danehans opened this issue Oct 10, 2022 · 4 comments · Fixed by #702
Labels
area/conformance Gateway API Conformance Related Issues kind/bug Something isn't working priority/high Label used to express the "high" priority level release-note Indicates a required release note
Milestone

Comments

@danehans
Copy link
Contributor

#471 added initial support for ReferenceGrants by allowing Gateways to reference Secrets in a different namespace. The gateway controller adds the ReferenceGrant and the ReferenceGrant namespace to the provider watchable map when:

  1. A Gateway listener references a Secret in a different namespace.
  2. A ReferenceGrant in the above namespace exists and permits the Gateways from the Gateway's namespace to Secrets.

When the Gateway is deleted, the ReferenceGrant and ReferenceGrant namespace should be deleted from the provider's watchable map if no other Gateway references the ReferenceGrant.

@skriss
Copy link
Contributor

skriss commented Oct 17, 2022

Note #580 (review), when this is fixed the two invalid/missing referencegrant conformance tests should be able to be uncommented.

@skriss skriss added the area/conformance Gateway API Conformance Related Issues label Oct 18, 2022
@danehans danehans added the release-note Indicates a required release note label Oct 18, 2022
@arkodg
Copy link
Contributor

arkodg commented Oct 19, 2022

I prefer if we move this to 0.3.0 . Based on current logic there is no easy way to handle deletes for RefGrants, easier to implement this with #413 where we dont need to handle deletes, just start from scratch with every reconcile.

@danehans
Copy link
Contributor Author

Being noted in the v0.2.0 release notes and moving to v0.3.0-rc.1.

@danehans danehans modified the milestones: 0.2.0, 0.3.0-rc.1 Oct 19, 2022
@danehans danehans added the priority/high Label used to express the "high" priority level label Nov 8, 2022
@chauhanshubham
Copy link
Member

chauhanshubham commented Nov 28, 2022

#702 fixes this issue and uncomment's the two conformance tests.

tests.GatewaySecretMissingReferenceGrant,
tests.GatewaySecretInvalidReferenceGrant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Gateway API Conformance Related Issues kind/bug Something isn't working priority/high Label used to express the "high" priority level release-note Indicates a required release note
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants