bazel: enable rules_foreign_cc vendored tools

[keith]

This reverts commit fed3d12.

The original change had an issue with macOS 12.3 removing the default python version.

bazel-contrib/rules_foreign_cc#900
ninja-build/ninja#2118

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

[repokitteh-read-only]

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20910 was opened by keith.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #20910 was opened by keith.

see: more, trace.

[keith]

no changes here yet, partially waiting to see what happens on the linked PRs

[jsharpe]

@keith note that the automake example in rules_foreign_cc is not usable yet as it depends on the autoconf build which doesn't work because it does generate relocatable output so I don't have a good way yet of making the autotools set of build tools hermetic yet.

Also worth noting that if you end up building cmake from source rather than using one of the precompiled binaries then openssl support is missing at the moment.

[keith]

@keith note that the automake example in rules_foreign_cc is not usable yet as it depends on the autoconf build which doesn't work because it does generate relocatable output so I don't have a good way yet of making the autotools set of build tools hermetic yet.

Thanks for the context, if we're not calling this directly that shouldn't affect us right? I only see make + cmake + ninja atm

Also worth noting that if you end up building cmake from source rather than using one of the precompiled binaries then openssl support is missing at the moment.

hrm good to know, I can probably look but what conditions would we build it, and when would we need openssl?

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[keith]

i need to update this once there's a new release of these rules

[wrowe]

/wait

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!