-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: enable rules_foreign_cc vendored tools #20910
bazel: enable rules_foreign_cc vendored tools #20910
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
no changes here yet, partially waiting to see what happens on the linked PRs |
@keith note that the automake example in rules_foreign_cc is not usable yet as it depends on the autoconf build which doesn't work because it does generate relocatable output so I don't have a good way yet of making the autotools set of build tools hermetic yet. Also worth noting that if you end up building cmake from source rather than using one of the precompiled binaries then openssl support is missing at the moment. |
Thanks for the context, if we're not calling this directly that shouldn't affect us right? I only see make + cmake + ninja atm
hrm good to know, I can probably look but what conditions would we build it, and when would we need openssl? |
This reverts commit fed3d12. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
769c17c
to
d341a57
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
i need to update this once there's a new release of these rules |
/wait |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This reverts commit fed3d12.
The original change had an issue with macOS 12.3 removing the default python version.
bazel-contrib/rules_foreign_cc#900
ninja-build/ninja#2118
Signed-off-by: Keith Smiley keithbsmiley@gmail.com