bazel: enable rules_foreign_cc vendored tools

[keith]

This makes it so you don't have to have cmake, make, or ninja installed,
or worry about version issues between them.

Since 0.1.0 rules_foreign_cc has supported vendoring these tools https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.1.0 and it builds them with cross platform scripts for bootstrapping.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

[repokitteh-read-only]

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20517 was opened by keith.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #20517 was opened by keith.

see: more, trace.

[htuch]

@keith this seems magically good. Can you link to the upstream description in rules_foreign_cc around how this works? Are we pulling in things like cmake via the rules_foreign_cc dependency? How does that work across all platforms?

[keith]

Updated the description a bit! Yea it should work cross platform, they use some scripts for make, and then make for cmake.

[htuch]

LGTM - should https://github.com/envoyproxy/envoy/blob/main/bazel/README.md#quick-start-bazel-build-for-developers also be updated to reduce packages that are subsumed here?

[keith]

Ah yes! updated here. I'm not actually sure how automake played into things though 🤔 that one might still be required.

[moderation]

/lgtm deps

[htuch]

LGTM, thanks!

[moderation]

I'm getting the following error on Apple M1. Maybe I need a bazel clean --expunge ?

ERROR: /private/var/tmp/_bazel_moderation/3335c71f4281d4576473beb63d032778/external/rules_foreign_cc/toolchains/BUILD.bazel:147:11: BootstrapNinjaBuild external/rules_foreign_cc/toolchains/ninja failed: (Exit 127): bash failed: error executing command /bin/bash -c bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/wrapper_build_script.sh

Use --sandbox_debug to see verbose messages from the sandbox
rules_foreign_cc: Build failed!
rules_foreign_cc: Keeping temp build directory and dependencies directory for debug.
rules_foreign_cc: Please note that the directories inside a sandbox are still cleaned unless you specify --sandbox_debug Bazel command line flag.
rules_foreign_cc: Printing build logs:
_____ BEGIN BUILD LOGS _____
+ ./configure.py --bootstrap
env: python: No such file or directory
_____ END BUILD LOGS _____
rules_foreign_cc: Build wrapper script location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/wrapper_build_script.sh
rules_foreign_cc: Build script location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/build_script.sh
rules_foreign_cc: Build log location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/BootstrapNinjaBuild.log

Target //source/exe:envoy-static.stripped failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /private/var/tmp/_bazel_moderation/3335c71f4281d4576473beb63d032778/external/envoy_api/envoy/type/v3/BUILD:7:18 Middleman _middlemen/@envoy_Uapi_S_Senvoy_Stype_Sv3_Cpkg-BazelCppSemantics_build_arch_darwin_arm64-opt failed: (Exit 127): bash failed: error executing command /bin/bash -c bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/ninja_tool_foreign_cc/wrapper_build_script.sh

Use --sandbox_debug to see verbose messages from the sandbox
INFO: Elapsed time: 4.012s, Critical Path: 2.36s
INFO: 37 processes: 13 internal, 24 darwin-sandbox.
FAILED: Build did NOT complete successfully

[keith]

Oof. Something depends on python2 it looks like:

 ./configure.py --bootstrap
env: python: No such file or directory

I haven't updated to the version that drops it yet. I'll submit a revert.

[keith]

#20899

[keith]

working on the new version here #20910