-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: enable rules_foreign_cc vendored tools #20517
bazel: enable rules_foreign_cc vendored tools #20517
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
@keith this seems magically good. Can you link to the upstream description in |
4ced78c
to
38dbd9f
Compare
Updated the description a bit! Yea it should work cross platform, they use some scripts for make, and then make for cmake. |
LGTM - should https://github.com/envoyproxy/envoy/blob/main/bazel/README.md#quick-start-bazel-build-for-developers also be updated to reduce packages that are subsumed here? |
This makes it so you don't have to have cmake, make, or ninja installed, or worry about version issues between them. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
ae4f7c6
to
e089579
Compare
Ah yes! updated here. I'm not actually sure how automake played into things though 🤔 that one might still be required. |
/lgtm deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'm getting the following error on Apple M1. Maybe I need a
|
Oof. Something depends on python2 it looks like:
I haven't updated to the version that drops it yet. I'll submit a revert. |
This reverts commit 9141f23. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This reverts commit 9141f23. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
working on the new version here #20910 |
This makes it so you don't have to have cmake, make, or ninja installed, or worry about version issues between them. Since 0.1.0 rules_foreign_cc has supported vendoring these tools https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.1.0 and it builds them with cross platform scripts for bootstrapping. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
…)" This reverts commit 9141f23. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This makes it so you don't have to have cmake, make, or ninja installed,
or worry about version issues between them.
Since 0.1.0 rules_foreign_cc has supported vendoring these tools https://github.com/bazelbuild/rules_foreign_cc/releases/tag/0.1.0 and it builds them with cross platform scripts for bootstrapping.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com