Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed --use-fake-symbol-table option. #14178

Merged
merged 6 commits into from
Nov 28, 2020
Merged

Removed --use-fake-symbol-table option. #14178

merged 6 commits into from
Nov 28, 2020

Conversation

mk46
Copy link
Contributor

@mk46 mk46 commented Nov 25, 2020 •
edited
Loading

Signed-off-by: Manish Kumar manish.kumar1@india.nec.com

Commit Message: Removed --use-fake-symbol-table option.
Additional Description: Removing --use-fake-symbol-table because code for supporting the fake symbol table had been removed by #6307
Risk Level:
Testing: unit and format test
Docs Changes: admin.rst
Release Notes: done
Fixes #13399
Deprecated: --use-fake-symbol-table option

Removed --use-fake-symbol-table option.
92968a4 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46
Copy link
Contributor Author

mk46 commented Nov 25, 2020

/cc @jmarantz

@mk46 mk46 marked this pull request as draft November 25, 2020 03:38
Fixing typos.
e797153 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@jmarantz jmarantz self-assigned this Nov 25, 2020
Removing TODO(envoyproxy#6307).
2ea17a8 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46 mk46 marked this pull request as ready for review November 25, 2020 04:24
Fixed CI.
30c929b 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46
Copy link
Contributor Author

mk46 commented Nov 25, 2020

@jmarantz Would you mind to take a look? Thanks!

jmarantz
jmarantz reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically looks good, with one opportunity for further cleanup or leave the TODO in place (your choice).

include/envoy/stats/symbol_table.h Show resolved Hide resolved
Removed callWithStringView
4bfdc57 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46
Copy link
Contributor Author

mk46 commented Nov 26, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #14178 (comment) was created by @mk46.

see: more, trace.

jmarantz
jmarantz reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more slight edit needed in https://github.com/envoyproxy/envoy/blob/master/source/docs/stats.md to just delete the paragraph:

As of October 6, 2020, the "fake" symbol table implementation has been removed from the system, and the "--use-fake-symbol-table" option is now a no-op, triggering a warning if set to "1". The option will be removed in a later release.

jmarantz
jmarantz previously approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@jmarantz jmarantz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great modulo last stats.md edit and @envoyproxy/senior-maintainers approval.

include/envoy/stats/symbol_table.h Show resolved Hide resolved
Updated source/docs/stats.md
d1c896d 
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46
Copy link
Contributor Author

mk46 commented Nov 27, 2020

There's one more slight edit needed in https://github.com/envoyproxy/envoy/blob/master/source/docs/stats.md to just delete the paragraph:

As of October 6, 2020, the "fake" symbol table implementation has been removed from the system, and the "--use-fake-symbol-table" option is now a no-op, triggering a warning if set to "1". The option will be removed in a later release.

Done.

@mattklein123 mattklein123 self-assigned this Nov 27, 2020
mattklein123
mattklein123 approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mattklein123 mattklein123 merged commit c0a0449 into envoyproxy:master Nov 28, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 2, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
8cd1560 
* master: (70 commits)
  upstream: avoid reset after end_stream in TCP HTTP upstream (envoyproxy#14106)
  bazelci: add fuzz coverage (envoyproxy#14179)
  dependencies: allowlist CVE-2020-8277 to prevent false positives. (envoyproxy#14228)
  cleanup: replace ad-hoc [0, 1] value types with UnitFloat (envoyproxy#14081)
  Update docs for skywalking tracer (envoyproxy#14210)
  Fix some errors in the switch statement when decode dubbo response (envoyproxy#14207)
  Windows: enable tests and envoy-static.exe pdb file (envoyproxy#13688)
  http: add Kill Request HTTP filter (envoyproxy#14170)
  dependencies: fix release_dates error behavior. (envoyproxy#14216)
  thrift filter: support skip decoding data after metadata in the thrift message (envoyproxy#13592)
  update cares (envoyproxy#14213)
  docs: clarify behavior of hedge_on_per_try_timeout (envoyproxy#12983)
  repokitteh: add support for randomized auto-assign. (envoyproxy#14185)
  [grpc] validate grpc config for illegal characters (envoyproxy#14129)
  server: Return nullopt when process_context is nullptr (envoyproxy#14181)
  [Windows] Fix thrift proxy tests (envoyproxy#13220)
  kafka: add missing unit tests (envoyproxy#14195)
  doc: mention gperftools explicitly in PPROF.md (envoyproxy#14199)
  Removed `--use-fake-symbol-table` option. (envoyproxy#14178)
  filter contract: clarification around local replies (envoyproxy#14193)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@jmarantz jmarantz jmarantz left review comments

Assignees

@jmarantz jmarantz

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stats: Remove --use-fake-symbol-tables option.
3 participants
@mk46 @jmarantz @mattklein123