Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: Remove --use-fake-symbol-tables option. #13399

Closed
jmarantz opened this issue Oct 6, 2020 · 3 comments · Fixed by #14178
Closed

stats: Remove --use-fake-symbol-tables option. #13399

jmarantz opened this issue Oct 6, 2020 · 3 comments · Fixed by #14178
Assignees
Labels
area/stats bug no stalebot Disables stalebot from closing an issue
Milestone

Comments

@jmarantz
Copy link
Contributor

jmarantz commented Oct 6, 2020

See also #6307 which removes the code supporting fake symbol tables, but leaves the option in place.

Removing the option is a breaking change, so splitting that off on its own.

@jmarantz jmarantz added bug triage Issue requires triage area/stats and removed triage Issue requires triage labels Oct 6, 2020
@jmarantz jmarantz self-assigned this Oct 6, 2020
@mattklein123 mattklein123 added the no stalebot Disables stalebot from closing an issue label Oct 6, 2020
@mattklein123 mattklein123 added this to the 1.17.0 milestone Oct 6, 2020
@mk46
Copy link
Contributor

mk46 commented Nov 24, 2020

Hi @jmarantz, I would like to take it if you're not working on it.

@jmarantz
Copy link
Contributor Author

You are welcome to take it; I expect it will be pretty easy and I can review. However, I think it would be better to wait a bit, because removing an option can break production setups, potentially. @mattklein123 when do you think would be appropriate? Maybe 1-2 weeks prior to the cut-date for 1.17?

@mattklein123
Copy link
Member

If the code was removed in the last release IMO it can be removed any time during this cycle so fine to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/stats bug no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants