benchmark: Skip expensive setup and benchmarks to avoid filter_chain_benchmark_test_benchmark_test timeouts under tsan #12264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enchmark_test_benchmark_test timeouts under tsan also, bump up the googlebenchmark version to pickup the fix to SkipWithError, google/benchmark#938 Signed-off-by: Antonio Vicente <avd@google.com>
|
This tidy issues are pre-existing I think so will merge to remove this flake. |
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
…enchmark_test_benchmark_test timeouts under tsan (envoyproxy#12264) also, bump up the googlebenchmark version to pickup the fix to SkipWithError, google/benchmark#938 Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
…enchmark_test_benchmark_test timeouts under tsan (envoyproxy#12264) also, bump up the googlebenchmark version to pickup the fix to SkipWithError, google/benchmark#938 Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
benchmark: Skip expensive setup and benchmarks to avoid filter_chain_benchmark_test_benchmark_test timeouts under tsan.
Also, bump up the googlebenchmark version to pickup the fix to SkipWithError, google/benchmark#938 .
Additional Description:
Risk Level: n/a test-only
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #12242