filter_chain_benchmark_test_benchmark_test tsan flake

[mattklein123]

2020-07-23T00:06:20.5948156Z TIMEOUT: //test/server:filter_chain_benchmark_test_benchmark_test (Summary)
2020-07-23T00:06:20.5998332Z       /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy/bazel-out/k8-dbg/testlogs/test/server/filter_chain_benchmark_test_benchmark_test/test.log
2020-07-23T00:06:20.5998879Z ==================== Test output for //test/server:filter_chain_benchmark_test_benchmark_test:
2020-07-23T00:06:20.5999508Z [2020-07-22 23:51:22.419][19][critical][misc] Expensive benchmarks are being skipped; see test/README.md for more information
2020-07-23T00:06:20.5999952Z 2020-07-22 23:51:22
2020-07-23T00:06:20.6000481Z Running /b/f/w/bazel-out/k8-dbg/bin/test/server/filter_chain_benchmark_test_benchmark_test.runfiles/envoy/test/server/filter_chain_benchmark_test
2020-07-23T00:06:20.6000836Z Run on (2 X 2250 MHz CPU s)
2020-07-23T00:06:20.6001025Z CPU Caches:
2020-07-23T00:06:20.6001348Z   L1 Data 32K (x1)
2020-07-23T00:06:20.6001541Z   L1 Instruction 32K (x1)
2020-07-23T00:06:20.6001735Z   L2 Unified 512K (x1)
2020-07-23T00:06:20.6001917Z   L3 Unified 16384K (x1)
2020-07-23T00:06:20.6002125Z Load Average: 1.38, 1.18, 1.17
2020-07-23T00:06:20.6002385Z ***WARNING*** Library was built as DEBUG. Timings may be affected.
2020-07-23T00:06:20.6002911Z [2020-07-22 23:51:23.233][19][debug][config] new fc_contexts has 3 filter chains, including 3 newly built
2020-07-23T00:06:20.6003449Z -------------------------------------------------------------------------------------------------------
2020-07-23T00:06:20.6003841Z Benchmark                                                             Time             CPU   Iterations
2020-07-23T00:06:20.6004458Z -------------------------------------------------------------------------------------------------------
2020-07-23T00:06:20.6004841Z FilterChainBenchmarkFixture/FilterChainManagerBuildTest/1      19192398 ns     18954121 ns            1
2020-07-23T00:06:20.6005390Z [2020-07-22 23:51:24.760][19][debug][config] new fc_contexts has 10 filter chains, including 10 newly built
2020-07-23T00:06:20.6005781Z FilterChainBenchmarkFixture/FilterChainManagerBuildTest/8      71343691 ns     71345320 ns            1
2020-07-23T00:06:20.6006329Z [2020-07-22 23:51:31.722][19][debug][config] new fc_contexts has 66 filter chains, including 66 newly built
2020-07-23T00:06:20.6006730Z FilterChainBenchmarkFixture/FilterChainManagerBuildTest/64    552462296 ns    552178573 ns            1
2020-07-23T00:06:20.6007282Z [2020-07-22 23:52:21.731][19][debug][config] new fc_contexts has 514 filter chains, including 514 newly built
2020-07-23T00:06:20.6007690Z FilterChainBenchmarkFixture/FilterChainManagerBuildTest/512  4090699827 ns   4089874909 ns            1
2020-07-23T00:06:20.6008239Z [2020-07-22 23:58:51.792][19][debug][config] new fc_contexts has 4098 filter chains, including 4098 newly built
2020-07-23T00:06:20.6068120Z FilterChainBenchmarkFixture/FilterChainManagerBuildTest/4096 32562148278 ns   32556390826 ns            1
2020-07-23T00:06:20.6069516Z [2020-07-22 23:58:55.921][19][debug][config] new fc_contexts has 3 filter chains, including 3 newly built
2020-07-23T00:06:20.6070175Z FilterChainBenchmarkFixture/FilterChainFindTest/1                109550 ns       106830 ns            1
2020-07-23T00:06:20.6070965Z [2020-07-22 23:58:57.479][19][debug][config] new fc_contexts has 10 filter chains, including 10 newly built
2020-07-23T00:06:20.6071583Z FilterChainBenchmarkFixture/FilterChainFindTest/8                560229 ns       557259 ns            1
2020-07-23T00:06:20.6072765Z [2020-07-22 23:59:04.058][19][debug][config] new fc_contexts has 66 filter chains, including 66 newly built
2020-07-23T00:06:20.6073950Z FilterChainBenchmarkFixture/FilterChainFindTest/64              3571219 ns      3569130 ns            1
2020-07-23T00:06:20.6074667Z [2020-07-22 23:59:54.815][19][debug][config] new fc_contexts has 514 filter chains, including 514 newly built
2020-07-23T00:06:20.6075154Z FilterChainBenchmarkFixture/FilterChainFindTest/512            28730589 ns     28731850 ns            1
2020-07-23T00:06:20.6075685Z -- Test timed out at 2020-07-23 00:06:17 UTC --
2020-07-23T00:06:20.6076046Z ================================================================================
2020-07-23T00:06:20.6076446Z INFO: From Testing //test/server:filter_chain_benchmark_test_benchmark_test:

[mattklein123]

I've seen this flake multiple times on TSAN. I'm guessing the test is too expensive for that sanitizer. @antoniovicente any recommendations on how to fix?

[alyssawilk]

Do we need a benchmark on TSAN? This is the sort of thing I think we could just compile disable.

[mattklein123]

Theoretically it seems like it would catch some issues, but I would be fine disabling this type of thing on TSAN.

[antoniovicente]

We have a flag that pgenera added to skip expensive benchmarks when running the smoke tests, I'll look into how to reduce the runtime for this specific test.

[antoniovicente]

/assign @antoniovicente